(maven-enforcer) branch master updated: Remove unused collections

[mbuenger]

This is an automated email from the ASF dual-hosted git repository.

mbuenger pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-enforcer.git


The following commit(s) were added to refs/heads/master by this push:
     new aecf403  Remove unused collections
aecf403 is described below

commit aecf403ff7e9708a9fc0faf37ff473dcc6875425
Author: Elliotte Rusty Harold <elh...@users.noreply.github.com>
AuthorDate: Sun Feb 23 18:12:58 2025 +0000

    Remove unused collections
---
 .../java/org/apache/maven/enforcer/rules/RequireSameVersions.java   | 6 ------
 .../org/apache/maven/enforcer/rules/TestRequirePluginVersions.java  | 6 ------
 2 files changed, 12 deletions(-)

diff --git 
a/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireSameVersions.java
 
b/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireSameVersions.java
index 4f95766..df4477f 100644
--- 
a/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireSameVersions.java
+++ 
b/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireSameVersions.java
@@ -66,15 +66,9 @@ public final class RequireSameVersions extends 
AbstractStandardEnforcerRule {
 
     @Override
     public void execute() throws EnforcerRuleException {
-
         // consider including profile based artifacts
         Map<String, List<String>> versionMembers = new LinkedHashMap<>();
 
-        Set<String> buildPluginSet = new HashSet<>(buildPlugins);
-        buildPluginSet.addAll(plugins);
-        Set<String> reportPluginSet = new HashSet<>(reportPlugins);
-        reportPluginSet.addAll(plugins);
-
         // CHECKSTYLE_OFF: LineLength
         versionMembers.putAll(collectVersionMembers(project.getArtifacts(), 
dependencies, " (dependency)"));
         
versionMembers.putAll(collectVersionMembers(project.getPluginArtifacts(), 
buildPlugins, " (buildPlugin)"));
diff --git 
a/enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/TestRequirePluginVersions.java
 
b/enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/TestRequirePluginVersions.java
index 8f19cba..511ca40 100644
--- 
a/enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/TestRequirePluginVersions.java
+++ 
b/enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/TestRequirePluginVersions.java
@@ -289,12 +289,6 @@ class TestRequirePluginVersions {
      */
     @Test
     void testGetAdditionalPluginsEmptySet() throws Exception {
-
-        Set<Plugin> plugins = new HashSet<>();
-        plugins.add(EnforcerTestUtils.newPlugin("group", "a-artifact", "1.0"));
-        plugins.add(EnforcerTestUtils.newPlugin("group", "foo", null));
-        plugins.add(EnforcerTestUtils.newPlugin("group", "foo2", ""));
-
         List<String> additional = new ArrayList<>();
         additional.add("group:a-artifact");
         additional.add("group:another-artifact");