(maven-enforcer) branch master updated: Eliminate some string operations

[mbuenger]

This is an automated email from the ASF dual-hosted git repository.

mbuenger pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-enforcer.git


The following commit(s) were added to refs/heads/master by this push:
     new c79644f  Eliminate some string operations
c79644f is described below

commit c79644f56c5990278c3aa5da0fecc1a0d8c431a8
Author: Elliotte Rusty Harold <elh...@users.noreply.github.com>
AuthorDate: Sun Feb 23 18:11:53 2025 +0000

    Eliminate some string operations
---
 .../java/org/apache/maven/enforcer/rules/BannedRepositories.java | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git 
a/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/BannedRepositories.java
 
b/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/BannedRepositories.java
index 4b67f91..8347965 100644
--- 
a/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/BannedRepositories.java
+++ 
b/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/BannedRepositories.java
@@ -161,18 +161,17 @@ public final class BannedRepositories extends 
AbstractStandardEnforcerRule {
     }
 
     private String populateErrorMessage(List<ArtifactRepository> 
resultBannedRepos, String errorMessagePrefix) {
-        StringBuffer errMsg = new StringBuffer("");
         if (!resultBannedRepos.isEmpty()) {
-            errMsg.append("Current maven session contains banned" + 
errorMessagePrefix
+            return "Current maven session contains banned" + errorMessagePrefix
                     + "repository urls, please double check your pom or 
settings.xml:" + System.lineSeparator()
-                    + getRepositoryUrlString(resultBannedRepos) + 
System.lineSeparator() + System.lineSeparator());
+                    + getRepositoryUrlString(resultBannedRepos) + 
System.lineSeparator() + System.lineSeparator();
         }
 
-        return errMsg.toString();
+        return "";
     }
 
     private String getRepositoryUrlString(List<ArtifactRepository> 
resultBannedRepos) {
-        StringBuilder urls = new StringBuilder("");
+        StringBuilder urls = new StringBuilder();
         for (ArtifactRepository repo : resultBannedRepos) {
             urls.append(repo.getId() + " - " + repo.getUrl() + 
System.lineSeparator());
         }