This is an automated email from the ASF dual-hosted git repository. elharo pushed a commit to branch null in repository https://gitbox.apache.org/repos/asf/maven-enforcer.git
commit 01ad7fd8467f37b57bccf33aa6aac9b7fe071b28 Author: Elliotte Rusty Harold <elh...@ibiblio.org> AuthorDate: Sat Feb 22 19:43:53 2025 -0500 Remove unused collections --- .../java/org/apache/maven/enforcer/rules/RequireSameVersions.java | 6 ------ .../org/apache/maven/enforcer/rules/TestRequirePluginVersions.java | 6 ------ 2 files changed, 12 deletions(-) diff --git a/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireSameVersions.java b/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireSameVersions.java index 4f95766..df4477f 100644 --- a/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireSameVersions.java +++ b/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireSameVersions.java @@ -66,15 +66,9 @@ public final class RequireSameVersions extends AbstractStandardEnforcerRule { @Override public void execute() throws EnforcerRuleException { - // consider including profile based artifacts Map<String, List<String>> versionMembers = new LinkedHashMap<>(); - Set<String> buildPluginSet = new HashSet<>(buildPlugins); - buildPluginSet.addAll(plugins); - Set<String> reportPluginSet = new HashSet<>(reportPlugins); - reportPluginSet.addAll(plugins); - // CHECKSTYLE_OFF: LineLength versionMembers.putAll(collectVersionMembers(project.getArtifacts(), dependencies, " (dependency)")); versionMembers.putAll(collectVersionMembers(project.getPluginArtifacts(), buildPlugins, " (buildPlugin)")); diff --git a/enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/TestRequirePluginVersions.java b/enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/TestRequirePluginVersions.java index 8f19cba..511ca40 100644 --- a/enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/TestRequirePluginVersions.java +++ b/enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/TestRequirePluginVersions.java @@ -289,12 +289,6 @@ class TestRequirePluginVersions { */ @Test void testGetAdditionalPluginsEmptySet() throws Exception { - - Set<Plugin> plugins = new HashSet<>(); - plugins.add(EnforcerTestUtils.newPlugin("group", "a-artifact", "1.0")); - plugins.add(EnforcerTestUtils.newPlugin("group", "foo", null)); - plugins.add(EnforcerTestUtils.newPlugin("group", "foo2", "")); - List<String> additional = new ArrayList<>(); additional.add("group:a-artifact"); additional.add("group:another-artifact");