(maven-javadoc-plugin) branch master updated: Don't try to modify project source roots (#358)

[olamy]

This is an automated email from the ASF dual-hosted git repository.

olamy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-javadoc-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 235da55d Don't try to modify project source roots (#358)
235da55d is described below

commit 235da55d7bb9c8679fb8ac740c703cef763c5b01
Author: Stefan Oehme <st.oe...@gmail.com>
AuthorDate: Mon Feb 3 10:00:08 2025 +0100

    Don't try to modify project source roots (#358)
    
    The aggregate javadoc mojo was calling `addAll` directly on the list 
returned by `project.getCompileSourceRoots`. This bug was silently ignored by 
Maven 3, but results in an `UnsupportedOperationException` on Maven 4.
    
    Do a defensive copy instead.
---
 src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java 
b/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
index bea70c7f..6b915fe5 100644
--- a/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
+++ b/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
@@ -2201,7 +2201,7 @@ public abstract class AbstractJavadocMojo extends 
AbstractMojo {
                     if (subProject != project) {
                         Collection<Path> additionalSourcePaths = new 
ArrayList<>();
 
-                        List<String> sourceRoots = 
getProjectSourceRoots(subProject);
+                        List<String> sourceRoots = new 
ArrayList<>(getProjectSourceRoots(subProject));
 
                         if (subProject.getExecutionProject() != null) {
                             
sourceRoots.addAll(getExecutionProjectSourceRoots(subProject));