(maven-resolver) branch master updated: [MRESOLVER-653] NPE in case of failed result (#640)

[cstamas]

This is an automated email from the ASF dual-hosted git repository.

cstamas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git


The following commit(s) were added to refs/heads/master by this push:
     new beab5309 [MRESOLVER-653] NPE in case of failed result (#640)
beab5309 is described below

commit beab5309de2eaeaa3b9ce2de6b4b3525c64b3ace
Author: Tamas Cservenak <ta...@cservenak.net>
AuthorDate: Sun Jan 26 20:05:29 2025 +0100

    [MRESOLVER-653] NPE in case of failed result (#640)
    
    Obvious typo: result artifact may be null, it is request artifact that 
wanted to be checked. Added UT as well.
    
    ---
    
    https://issues.apache.org/jira/browse/MRESOLVER-653
---
 .../TrustedChecksumsArtifactResolverPostProcessor.java           | 2 +-
 .../TrustedChecksumsArtifactResolverPostProcessorTest.java       | 9 +++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessor.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessor.java
index 95e59485..2e45262b 100644
--- 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessor.java
+++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessor.java
@@ -162,7 +162,7 @@ public final class 
TrustedChecksumsArtifactResolverPostProcessor extends Artifac
         final boolean snapshots = ConfigUtils.getBoolean(session, false, 
CONFIG_PROP_SNAPSHOTS);
 
         for (ArtifactResult artifactResult : artifactResults) {
-            if (artifactResult.getArtifact().isSnapshot() && !snapshots) {
+            if (artifactResult.getRequest().getArtifact().isSnapshot() && 
!snapshots) {
                 continue;
             }
             if (artifactResult.isResolved()) {
diff --git 
a/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessorTest.java
 
b/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessorTest.java
index e57f1658..0aab40d1 100644
--- 
a/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessorTest.java
+++ 
b/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessorTest.java
@@ -149,6 +149,15 @@ public class 
TrustedChecksumsArtifactResolverPostProcessorTest implements Truste
         assertTrue(artifactResult.isResolved());
     }
 
+    @Test
+    void unresolvedArtifact() {
+        ArtifactResult artifactResult =
+                
createArtifactResult(artifactWithTrustedChecksum).setArtifact(null);
+        assertFalse(artifactResult.isResolved());
+
+        subject.postProcess(session, 
Collections.singletonList(artifactResult)); // no NPE
+    }
+
     @Test
     void haveNoChecksumPass() {
         ArtifactResult artifactResult = 
createArtifactResult(artifactWithoutTrustedChecksum);