This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch guice
in repository https://gitbox.apache.org/repos/asf/maven-changelog-plugin.git
The following commit(s) were added to refs/heads/guice by this push:
new 297c94b Remove dependency on commons-lang
297c94b is described below
commit 297c94b1704ede970d05a26c28d87bb704640361
Author: Elliotte Rusty Harold <elh...@ibiblio.org>
AuthorDate: Mon Dec 16 18:25:19 2024 -0500
Remove dependency on commons-lang
---
pom.xml | 5 -----
.../org/apache/maven/plugins/changelog/FileActivityComparator.java | 5 ++---
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/pom.xml b/pom.xml
index e0f8d20..cec19aa 100644
--- a/pom.xml
+++ b/pom.xml
@@ -214,11 +214,6 @@ under the License.
</exclusion>
</exclusions>
</dependency>
- <dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-lang3</artifactId>
- <version>3.17.0</version>
- </dependency>
<!-- doxia -->
<dependency>
diff --git
a/src/main/java/org/apache/maven/plugins/changelog/FileActivityComparator.java
b/src/main/java/org/apache/maven/plugins/changelog/FileActivityComparator.java
index c444e6e..30e7a68 100644
---
a/src/main/java/org/apache/maven/plugins/changelog/FileActivityComparator.java
+++
b/src/main/java/org/apache/maven/plugins/changelog/FileActivityComparator.java
@@ -21,7 +21,6 @@ package org.apache.maven.plugins.changelog;
import java.util.Comparator;
import java.util.List;
-import org.apache.commons.lang3.StringUtils;
import org.apache.maven.scm.ChangeFile;
/**
@@ -79,7 +78,7 @@ public class FileActivityComparator implements
Comparator<List<ChangeFile>> {
String latest = "";
for (ChangeFile file : list) {
- if (StringUtils.isNotBlank(latest)) {
+ if (latest != null && !latest.trim().isEmpty()) {
latest = file.getRevision();
} else if (latest.compareTo(file.getRevision()) < 0) {
latest = file.getRevision();
@@ -91,7 +90,7 @@ public class FileActivityComparator implements
Comparator<List<ChangeFile>> {
/**
* compares list1 and list2 by comparing their filenames. Least priority
sorting when both number of commits and
- * and revision are the same
+ * revision are the same
*
* @param list1 the first object in a compare statement
* @param list2 the object to compare list1 against
