(maven-shade-plugin) branch master updated: Reduce duplicate tests for ApacheNoticeResourceTransformer

[slachiewicz]

This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-shade-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new df959ee  Reduce duplicate tests for ApacheNoticeResourceTransformer
df959ee is described below

commit df959ee68271f3cae9d77dcff0c20c7045da07e2
Author: Goooler <wangzong...@gmail.com>
AuthorDate: Sat Nov 30 16:13:22 2024 +0800

    Reduce duplicate tests for ApacheNoticeResourceTransformer
    
    I missed that it's already in ApacheNoticeResourceTransformerTest.
    Follow up 437eff918fa31d7461290dd20bad79eee975b686.
---
 .../ApacheNoticeResourceTransformerParameterTests.java         | 10 ----------
 .../shade/resource/ApacheNoticeResourceTransformerTest.java    |  1 +
 2 files changed, 1 insertion(+), 10 deletions(-)

diff --git 
a/src/test/java/org/apache/maven/plugins/shade/resource/ApacheNoticeResourceTransformerParameterTests.java
 
b/src/test/java/org/apache/maven/plugins/shade/resource/ApacheNoticeResourceTransformerParameterTests.java
index 32f6cf1..cd61ca3 100644
--- 
a/src/test/java/org/apache/maven/plugins/shade/resource/ApacheNoticeResourceTransformerParameterTests.java
+++ 
b/src/test/java/org/apache/maven/plugins/shade/resource/ApacheNoticeResourceTransformerParameterTests.java
@@ -27,7 +27,6 @@ import org.apache.maven.plugins.shade.relocation.Relocator;
 import org.junit.Before;
 import org.junit.Test;
 
-import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
 /**
@@ -43,15 +42,6 @@ public class ApacheNoticeResourceTransformerParameterTests {
         subject = new ApacheNoticeResourceTransformer();
     }
 
-    @Test
-    public void testCanTransformResource() {
-        assertTrue(subject.canTransformResource("META-INF/NOTICE"));
-        assertTrue(subject.canTransformResource("META-INF/NOTICE.TXT"));
-        assertTrue(subject.canTransformResource("META-INF/NOTICE.md"));
-        assertTrue(subject.canTransformResource("META-INF/Notice.txt"));
-        assertTrue(subject.canTransformResource("META-INF/Notice.md"));
-    }
-
     @Test
     public void testNoParametersShouldNotThrowNullPointerWhenNoInput() throws 
IOException {
         processAndFailOnNullPointer("");
diff --git 
a/src/test/java/org/apache/maven/plugins/shade/resource/ApacheNoticeResourceTransformerTest.java
 
b/src/test/java/org/apache/maven/plugins/shade/resource/ApacheNoticeResourceTransformerTest.java
index f1a569f..d5cada8 100644
--- 
a/src/test/java/org/apache/maven/plugins/shade/resource/ApacheNoticeResourceTransformerTest.java
+++ 
b/src/test/java/org/apache/maven/plugins/shade/resource/ApacheNoticeResourceTransformerTest.java
@@ -54,6 +54,7 @@ public class ApacheNoticeResourceTransformerTest {
         assertTrue(transformer.canTransformResource("META-INF/NOTICE.TXT"));
         assertTrue(transformer.canTransformResource("META-INF/NOTICE.md"));
         assertTrue(transformer.canTransformResource("META-INF/Notice.txt"));
+        assertTrue(transformer.canTransformResource("META-INF/Notice.md"));
         assertFalse(transformer.canTransformResource("META-INF/MANIFEST.MF"));
     }
 }