This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch elharo-patch-4
in repository https://gitbox.apache.org/repos/asf/maven-site.git
commit ae5a6e7139a614482e1115d4b4f764704f6e442a
Author: Elliotte Rusty Harold <elh...@users.noreply.github.com>
AuthorDate: Wed Oct 23 16:44:09 2024 +0000
We almiost use exclusively use Github PRs nowadays instead of patches
---
content/apt/guides/development/guide-committer-school.apt | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/content/apt/guides/development/guide-committer-school.apt
b/content/apt/guides/development/guide-committer-school.apt
index 6c6aa22c..62d80890 100644
--- a/content/apt/guides/development/guide-committer-school.apt
+++ b/content/apt/guides/development/guide-committer-school.apt
@@ -38,11 +38,11 @@ Do you want to become a Maven Committer?
Maven is an Apache project, that means that we have to follow the Apache
rules and way.
One of those rules is that we cannot hand out commit access to anyone who
asks for it.
- To gain commit access you must establish your merit by submitting patches
that get picked up by existing committers.
+ To gain commit access you must establish your merit by submitting OPRs that
get approved by existing committers.
After you have contributed enough patches to establish merit, the project
management committee decides whether you can be trusted with commit access.
- <The reality is that "It is what it is"TL;DR To become a Maven committer
write good patches and get them applied.>
+ <The reality is that "It is what it is"TL;DR To become a Maven committer
write good PRs and get them merged.>
What makes a good patch?
@@ -62,7 +62,8 @@ password
This is in order to be sure that you have written an effective test case that
can pass for good data.
Then you implement the fix and all the tests should pass.
- You then take a Subversion compatible† diff of the source code and attach
that to the issue in question.
+ You then open a PR on Github and assign it to a committer who seems likely
to be
+ familiar or less familiar with that code based onp past activity.
To understand how your patch gets evaluated, here is how I apply patches:
@@ -154,4 +155,4 @@ Thanks
Personally, if I see somebody averaging a good patch a week for 2-3 months
and being active helping out on the
{{{mailto:us...@maven.apache.org}us...@maven.apache.org}} and
{{{mailto:d...@maven.apache.org}d...@maven.apache.org}} mailing lists then I
think I could make a strong case for such a person being given commit access.
- So if you think you have the right stuff and want to become a Maven
committer... class enrollment is open!
\ No newline at end of file
+ So if you think you have the right stuff and want to become a Maven
committer... class enrollment is open!
