This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch doxia-2.0.0 in repository https://gitbox.apache.org/repos/asf/maven-surefire.git
commit 3c4ae53a4897d44524824576fe2c808320db6d9a Author: Michael Osipov <micha...@apache.org> AuthorDate: Sun May 7 01:34:04 2023 +0200 Prepare for Doxia 2.0.0 --- maven-failsafe-plugin/pom.xml | 2 +- maven-surefire-common/pom.xml | 2 +- maven-surefire-plugin/pom.xml | 2 +- maven-surefire-report-plugin/pom.xml | 6 +- .../report/AbstractSurefireReportMojo.java | 10 +- .../surefire/report/SurefireReportRenderer.java | 103 +++++--------- .../src/main/resources/surefire-report.properties | 3 + .../main/resources/surefire-report_de.properties | 1 + .../main/resources/surefire-report_sv.properties | 1 + .../plugins/surefire/report/JUnit4SuiteTest.java | 2 +- .../plugins/surefire/report/Surefire597Test.java | 26 ++-- ...ReportMojoTest.java => SurefireReportTest.java} | 156 +++++++++++---------- ...nProjectStub2.java => AnchorTestCasesStub.java} | 17 +-- .../stubs/DependencyArtifactStubFactory.java | 23 --- ...RepMavenProjectStub2.java => EnclosedStub.java} | 17 +-- ...tStub2.java => EnclosedTrimStackTraceStub.java} | 17 +-- ...venProjectStub2.java => LinkXrefFalseStub.java} | 17 +-- ...MavenProjectStub2.java => NestedClassStub.java} | 17 +-- ...ub2.java => NestedClassTrimStackTraceStub.java} | 17 +-- ...pMavenProjectStub2.java => ReportTestStub.java} | 17 +-- ...venProjectStub2.java => ReportingNullStub.java} | 8 +- ...MavenProjectStub2.java => SingleErrorStub.java} | 17 +-- ...avenProjectStub2.java => SuccessFalseStub.java} | 17 +-- ...avenProjectStub2.java => Surefire1183Stub.java} | 17 +-- ...ub.java => SurefireReportMavenProjectStub.java} | 28 +++- .../plugin-config.xml | 3 +- .../plugin-config.xml | 3 +- .../plugin-config.xml | 3 +- .../plugin-config.xml | 3 +- .../basic-surefire-report-test/plugin-config.xml | 3 +- .../resources/unit/surefire-1183/plugin-config.xml | 3 +- .../plugin-config.xml | 3 +- .../surefire-report-enclosed/plugin-config.xml | 3 +- .../plugin-config.xml | 3 +- .../surefire-report-nestedClass/plugin-config.xml | 3 +- .../surefire-report-single-error/plugin-config.xml | 3 +- pom.xml | 26 +--- surefire-api/pom.xml | 2 +- surefire-booter/pom.xml | 2 +- surefire-extensions-api/pom.xml | 2 +- surefire-extensions-spi/pom.xml | 2 +- surefire-grouper/pom.xml | 2 +- surefire-its/pom.xml | 2 +- .../surefire-260-testWithIdenticalNames/pom.xml | 4 +- surefire-logger-api/pom.xml | 2 +- surefire-providers/common-java5/pom.xml | 2 +- surefire-providers/common-junit3/pom.xml | 2 +- surefire-providers/common-junit4/pom.xml | 2 +- surefire-providers/common-junit48/pom.xml | 2 +- surefire-providers/pom.xml | 2 +- surefire-providers/surefire-junit-platform/pom.xml | 2 +- surefire-providers/surefire-junit3/pom.xml | 2 +- surefire-providers/surefire-junit4/pom.xml | 2 +- surefire-providers/surefire-junit47/pom.xml | 2 +- surefire-providers/surefire-testng-utils/pom.xml | 2 +- surefire-providers/surefire-testng/pom.xml | 2 +- surefire-report-parser/pom.xml | 6 +- surefire-shadefire/pom.xml | 2 +- surefire-shared-utils/pom.xml | 2 +- 59 files changed, 246 insertions(+), 406 deletions(-) diff --git a/maven-failsafe-plugin/pom.xml b/maven-failsafe-plugin/pom.xml index 53327b826..a0cc69019 100644 --- a/maven-failsafe-plugin/pom.xml +++ b/maven-failsafe-plugin/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <groupId>org.apache.maven.plugins</groupId> diff --git a/maven-surefire-common/pom.xml b/maven-surefire-common/pom.xml index d4009434c..0c88aab20 100644 --- a/maven-surefire-common/pom.xml +++ b/maven-surefire-common/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>maven-surefire-common</artifactId> diff --git a/maven-surefire-plugin/pom.xml b/maven-surefire-plugin/pom.xml index 9d2d367d5..add2b0043 100644 --- a/maven-surefire-plugin/pom.xml +++ b/maven-surefire-plugin/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <groupId>org.apache.maven.plugins</groupId> diff --git a/maven-surefire-report-plugin/pom.xml b/maven-surefire-report-plugin/pom.xml index 714d94e3e..2c877bfda 100644 --- a/maven-surefire-report-plugin/pom.xml +++ b/maven-surefire-report-plugin/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <groupId>org.apache.maven.plugins</groupId> @@ -46,7 +46,7 @@ </prerequisites> <properties> - <doxiaVersion>1.11.1</doxiaVersion> + <doxiaVersion>2.0.0-M6</doxiaVersion> <aetherVersion>1.0.0.v20140518</aetherVersion> </properties> @@ -89,10 +89,12 @@ <dependency> <groupId>org.apache.maven.reporting</groupId> <artifactId>maven-reporting-api</artifactId> + <version>4.0.0-M6</version> </dependency> <dependency> <groupId>org.apache.maven.reporting</groupId> <artifactId>maven-reporting-impl</artifactId> + <version>4.0.0-M8</version> </dependency> <dependency> <groupId>org.fusesource.jansi</groupId> diff --git a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReportMojo.java b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReportMojo.java index a62d15bb0..d86436119 100644 --- a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReportMojo.java +++ b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReportMojo.java @@ -78,12 +78,6 @@ public abstract class AbstractSurefireReportMojo extends AbstractMavenReport { @Parameter private File reportsDirectory; - /** - * The projects in the reactor for aggregation report. - */ - @Parameter(defaultValue = "${reactorProjects}", readonly = true) - private List<MavenProject> reactorProjects; - /** * Location of the Xrefs to link. */ @@ -354,6 +348,10 @@ public abstract class AbstractSurefireReportMojo extends AbstractMavenReport { return project; } + protected List<MavenProject> getReactorProjects() { + return reactorProjects; + } + // TODO Review, especially Locale.getDefault() private static class CustomI18N implements I18N { private final MavenProject project; diff --git a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportRenderer.java b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportRenderer.java index 386dcdf8b..82fe023ea 100644 --- a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportRenderer.java +++ b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportRenderer.java @@ -19,7 +19,6 @@ package org.apache.maven.plugins.surefire.report; import java.io.File; -import java.text.NumberFormat; import java.util.List; import java.util.Locale; import java.util.Map; @@ -84,10 +83,10 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { * @return The translated string. */ private String getI18nString(String key) { - return getI18nString(getI18Nsection(), key); + return getI18nString(getI18nSection(), key); } - private String getI18Nsection() { + private String getI18nSection() { return i18nSection; } @@ -100,14 +99,19 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { return i18n.getString("surefire-report", locale, "report." + section + '.' + key); } + /** + * @param section The section. + * @param key The key to translate. + * @return the translated key. + */ + private String formatI18nString(String section, String key, Object... args) { + return i18n.format("surefire-report", locale, "report." + section + '.' + key, args); + } + public void renderBody() { javaScript(javascriptToggleDisplayCode()); - sink.section1(); - sink.sectionTitle1(); - sink.text(getTitle()); - sink.sectionTitle1_(); - sink.section1_(); + startSection(getTitle()); renderSectionSummary(); @@ -116,19 +120,14 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { renderSectionTestCases(); renderSectionFailureDetails(); + + endSection(); } private void renderSectionSummary() { Map<String, Object> summary = parser.getSummary(testSuites); - NumberFormat numberFormat = NumberFormat.getNumberInstance(locale); - NumberFormat percentFormat = NumberFormat.getPercentInstance(locale); - percentFormat.setMinimumFractionDigits(1); - sink.section1(); - sinkAnchor("Summary"); - sink.sectionTitle1(); - sink.text(getI18nString("surefire", "label.summary")); - sink.sectionTitle1_(); + startSection(getI18nString("surefire", "label.summary"), "Summary"); constructHotLinks(); @@ -150,8 +149,8 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { String.valueOf(summary.get("totalErrors")), String.valueOf(summary.get("totalFailures")), String.valueOf(summary.get("totalSkipped")), - percentFormat.format(summary.get("totalPercentage")), - numberFormat.format(summary.get("totalElapsedTime")) + " s" + formatI18nString("surefire", "value.successrate", summary.get("totalPercentage")), + formatI18nString("surefire", "value.time", summary.get("totalElapsedTime")) }); endTable(); @@ -162,7 +161,7 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { sink.lineBreak(); - sink.section1_(); + endSection(); } private void renderSectionPackages() { @@ -171,15 +170,7 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { return; } - NumberFormat numberFormat = NumberFormat.getNumberInstance(locale); - NumberFormat percentFormat = NumberFormat.getPercentInstance(locale); - percentFormat.setMinimumFractionDigits(1); - - sink.section1(); - sinkAnchor("Package_List"); - sink.sectionTitle1(); - sink.text(getI18nString("surefire", "label.packagelist")); - sink.sectionTitle1_(); + startSection(getI18nString("surefire", "label.packagelist"), "Package_List"); constructHotLinks(); @@ -205,13 +196,13 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { Map<String, Object> packageSummary = parser.getSummary(testSuiteList); tableRow(new String[] { - '{' + packageName + ", #" + packageName + '}', + createLinkPatternedText(packageName, '#' + packageName), String.valueOf(packageSummary.get("totalTests")), String.valueOf(packageSummary.get("totalErrors")), String.valueOf(packageSummary.get("totalFailures")), String.valueOf(packageSummary.get("totalSkipped")), - percentFormat.format(packageSummary.get("totalPercentage")), - numberFormat.format(packageSummary.get("totalElapsedTime")) + " s" + formatI18nString("surefire", "value.successrate", packageSummary.get("totalPercentage")), + formatI18nString("surefire", "value.time", packageSummary.get("totalElapsedTime")) }); } @@ -225,11 +216,7 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { List<ReportTestSuite> testSuiteList = entry.getValue(); - sink.section2(); - sinkAnchor(packageName); - sink.sectionTitle2(); - sink.text(packageName); - sink.sectionTitle2_(); + startSection(packageName); boolean showTable = false; @@ -264,19 +251,15 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { endTable(); } - sink.section2_(); + endSection(); } sink.lineBreak(); - sink.section1_(); + endSection(); } private void renderSectionTestSuite(ReportTestSuite suite) { - NumberFormat numberFormat = NumberFormat.getNumberInstance(locale); - NumberFormat percentFormat = NumberFormat.getPercentInstance(locale); - percentFormat.setMinimumFractionDigits(1); - sink.tableRow(); sink.tableCell(); @@ -297,7 +280,7 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { sink.tableCell_(); - tableCell('{' + suite.getName() + ", #" + suite.getPackageName() + '.' + suite.getName() + '}'); + tableCell(createLinkPatternedText(suite.getName(), '#' + suite.getPackageName() + '.' + suite.getName())); tableCell(Integer.toString(suite.getNumberOfTests())); @@ -310,9 +293,9 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { float percentage = parser.computePercentage( suite.getNumberOfTests(), suite.getNumberOfErrors(), suite.getNumberOfFailures(), suite.getNumberOfSkipped()); - tableCell(percentFormat.format(percentage)); + tableCell(formatI18nString("surefire", "value.successrate", percentage)); - tableCell(numberFormat.format(suite.getTimeElapsed()) + " s"); + tableCell(formatI18nString("surefire", "value.time", suite.getTimeElapsed())); sink.tableRow_(); } @@ -322,11 +305,7 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { return; } - sink.section1(); - sinkAnchor("Test_Cases"); - sink.sectionTitle1(); - sink.text(getI18nString("surefire", "label.testcases")); - sink.sectionTitle1_(); + startSection(getI18nString("surefire", "label.testcases"), "Test_Cases"); constructHotLinks(); @@ -334,11 +313,7 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { List<ReportTestCase> testCases = suite.getTestCases(); if (!testCases.isEmpty()) { - sink.section2(); - sinkAnchor(suite.getPackageName() + '.' + suite.getName()); - sink.sectionTitle2(); - sink.text(suite.getName()); - sink.sectionTitle2_(); + startSection(suite.getName(), suite.getPackageName() + '.' + suite.getName()); boolean showTable = false; @@ -362,18 +337,16 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { endTable(); } - sink.section2_(); + endSection(); } } sink.lineBreak(); - sink.section1_(); + endSection(); } private void constructTestCaseSection(ReportTestCase testCase) { - NumberFormat numberFormat = NumberFormat.getNumberInstance(locale); - sink.tableRow(); sink.tableCell(); @@ -427,7 +400,7 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { sinkCellAnchor(testCase.getName(), "TC_" + toHtmlId(testCase.getFullName())); } - tableCell(numberFormat.format(testCase.getTime()) + " s"); + tableCell(formatI18nString("surefire", "value.time", testCase.getTime())); sink.tableRow_(); @@ -460,7 +433,7 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { } private String toHtmlId(String id) { - return DoxiaUtils.isValidId(id) ? id : DoxiaUtils.encodeId(id, true); + return DoxiaUtils.isValidId(id) ? id : DoxiaUtils.encodeId(id); } private void renderSectionFailureDetails() { @@ -469,11 +442,7 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { return; } - sink.section1(); - sinkAnchor("Failure_Details"); - sink.sectionTitle1(); - sink.text(getI18nString("surefire", "label.failuredetails")); - sink.sectionTitle1_(); + startSection(getI18nString("surefire", "label.failuredetails"), "Failure_Details"); constructHotLinks(); @@ -540,7 +509,7 @@ public class SurefireReportRenderer extends AbstractMavenReportRenderer { sink.lineBreak(); - sink.section1_(); + endSection(); } private void constructHotLinks() { diff --git a/maven-surefire-report-plugin/src/main/resources/surefire-report.properties b/maven-surefire-report-plugin/src/main/resources/surefire-report.properties index 2b68fbb02..2159111af 100644 --- a/maven-surefire-report-plugin/src/main/resources/surefire-report.properties +++ b/maven-surefire-report-plugin/src/main/resources/surefire-report.properties @@ -35,6 +35,9 @@ report.surefire.label.testcases=Test Cases report.surefire.label.failuredetails=Failure Details report.surefire.text.note1=Note: failures are anticipated and checked for with assertions while errors are unanticipated. report.surefire.text.note2=Note: package statistics are not computed recursively, they only sum up all of its testsuites numbers. +report.surefire.value.successrate={0,choice,0#0%|0.0<{0,number,0.0%}|1#{0,number,0%}} +# Needs to be copied into other bundles only if non-Latin script is used +report.surefire.value.time={0,choice,0#0|0.0<{0,number,0.000}|1.0#{0,number,0.0}|1000#{0,number,0}} s report.failsafe.name=Failsafe report.failsafe.description=Report on the integration test results of the project. diff --git a/maven-surefire-report-plugin/src/main/resources/surefire-report_de.properties b/maven-surefire-report-plugin/src/main/resources/surefire-report_de.properties index 2a3bb905e..2867ac5d2 100644 --- a/maven-surefire-report-plugin/src/main/resources/surefire-report_de.properties +++ b/maven-surefire-report-plugin/src/main/resources/surefire-report_de.properties @@ -35,6 +35,7 @@ report.surefire.label.tests=Tests report.surefire.label.time =Zeit report.surefire.text.note1 =Hinweis: Fehlschl\u00E4ge werden erwartet und durch Behauptungen \u00FCberpr\u00FCft w\u00E4hrend Fehler unerwartet sind. report.surefire.text.note2 =Hinweis: Die Paketstatistiken werden nicht rekursiv berechnet, es werden lediglich die Ergebnisse aller enthaltenen Tests aufsummiert. +report.surefire.value.successrate={0,choice,0#0 %|0.0<{0,number,0.0 %}|1#{0,number,0 %}} report.failsafe.name=Failsafe report.failsafe.description=Bericht \u00FCber die Integrationstestresultate des Projekts. diff --git a/maven-surefire-report-plugin/src/main/resources/surefire-report_sv.properties b/maven-surefire-report-plugin/src/main/resources/surefire-report_sv.properties index 3b60a603c..d1b69679b 100644 --- a/maven-surefire-report-plugin/src/main/resources/surefire-report_sv.properties +++ b/maven-surefire-report-plugin/src/main/resources/surefire-report_sv.properties @@ -35,6 +35,7 @@ report.surefire.label.testcases=Testfall report.surefire.label.failuredetails=Detaljer om misslyckade tester report.surefire.text.note1=Notera: misslyckade tester \u00e4r f\u00f6rv\u00e4ntade och har kontrollerats med assertions medan felaktiga tester \u00e4r ov\u00e4ntade. report.surefire.text.note2=Notera: paketstatistiken ber\u00e4knas inte rekursivt, den summerar bara alla testsviters antal. +report.surefire.value.successrate={0,choice,0#0 %|0.0<{0,number,0.0 %}|1#{0,number,0 %}} report.failsafe.name=Failsafe report.failsafe.description=Rapport om integration testresultaten f\u00f6r projektet. diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/JUnit4SuiteTest.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/JUnit4SuiteTest.java index 74df21fec..fc1eaefd3 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/JUnit4SuiteTest.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/JUnit4SuiteTest.java @@ -34,7 +34,7 @@ public class JUnit4SuiteTest extends TestCase { TestSuite suite = new TestSuite(); suite.addTest(new JUnit4TestAdapter(Surefire597Test.class)); suite.addTest(new JUnit4TestAdapter(SurefireSchemaValidationTest.class)); - suite.addTestSuite(SurefireReportMojoTest.class); + suite.addTestSuite(SurefireReportTest.class); return suite; } } diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java index f1a45fdc2..7be7c0a50 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java @@ -53,7 +53,7 @@ public class Surefire597Test extends TestCase { String xml = writer.toString(); assertThat( xml, - containsString(toSystemNewLine("<table border=\"0\" class=\"bodyTable\">\n" + containsString(toSystemNewLine("<table class=\"bodyTable\">\n" + "<tr class=\"a\">\n" + "<th>Tests</th>\n" + "<th>Errors</th>\n" @@ -62,17 +62,17 @@ public class Surefire597Test extends TestCase { + "<th>Success Rate</th>\n" + "<th>Time</th></tr>\n" + "<tr class=\"b\">\n" - + "<td align=\"left\">1</td>\n" + + "<td>1</td>\n" + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td>" + "</tr>" + "</table>"))); assertThat( xml, - containsString(toSystemNewLine("<table border=\"0\" class=\"bodyTable\">\n" + containsString(toSystemNewLine("<table class=\"bodyTable\">\n" + "<tr class=\"a\">\n" + "<th>Package</th>\n" + "<th>Tests</th>\n" @@ -82,16 +82,16 @@ public class Surefire597Test extends TestCase { + "<th>Success Rate</th>\n" + "<th>Time</th></tr>\n" + "<tr class=\"b\">\n" - + "<td align=\"left\"><a href=\"#surefire\">surefire</a></td>\n" + + "<td><a href=\"#surefire\">surefire</a></td>\n" + "<td>1</td>\n" + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td></tr></table>"))); assertThat( xml, - containsString(toSystemNewLine("<table border=\"0\" class=\"bodyTable\">\n" + containsString(toSystemNewLine("<table class=\"bodyTable\">\n" + "<tr class=\"a\">\n" + "<th>-</th>\n" + "<th>Class</th>\n" @@ -102,25 +102,25 @@ public class Surefire597Test extends TestCase { + "<th>Success Rate</th>\n" + "<th>Time</th></tr>\n" + "<tr class=\"b\">\n" - + "<td align=\"left\"><a href=\"#surefire.MyTest\"><img src=\"images/icon_error_sml.gif\" alt=\"\" /></a></td>\n" + + "<td><a href=\"#surefire.MyTest\"><img src=\"images/icon_error_sml.gif\" /></a></td>\n" + "<td><a href=\"#surefire.MyTest\">MyTest</a></td>\n" + "<td>1</td>\n" + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td></tr></table>"))); assertThat( xml, - containsString(toSystemNewLine("<table border=\"0\" class=\"bodyTable\">\n" + containsString(toSystemNewLine("<table class=\"bodyTable\">\n" + "<tr class=\"a\">\n" - + "<td align=\"left\"><img src=\"images/icon_error_sml.gif\" alt=\"\" /></td>\n" + + "<td><img src=\"images/icon_error_sml.gif\" /></td>\n" + "<td><a id=\"surefire.MyTest.test\"></a>test</td></tr>\n" + "<tr class=\"b\">\n" - + "<td align=\"left\">-</td>\n" + + "<td>-</td>\n" + "<td>java.lang.RuntimeException: java.lang.IndexOutOfBoundsException: msg</td></tr>\n" + "<tr class=\"a\">\n" - + "<td align=\"left\">-</td>\n" + + "<td>-</td>\n" + "<td>\n" + "<div id=\"test-error\">surefire.MyTest:13</div></td></tr></table>"))); } diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportMojoTest.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportTest.java similarity index 87% rename from maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportMojoTest.java rename to maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportTest.java index 1b2634aaf..b930b734d 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportMojoTest.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/SurefireReportTest.java @@ -19,16 +19,19 @@ package org.apache.maven.plugins.surefire.report; import java.io.File; -import java.io.UnsupportedEncodingException; -import java.net.URL; -import java.net.URLDecoder; -import java.util.Locale; +import java.util.Collections; +import java.util.List; +import org.apache.maven.model.Plugin; import org.apache.maven.plugin.LegacySupport; +import org.apache.maven.plugin.MojoExecution; +import org.apache.maven.plugin.descriptor.MojoDescriptor; +import org.apache.maven.plugin.descriptor.PluginDescriptor; import org.apache.maven.plugin.testing.AbstractMojoTestCase; import org.apache.maven.plugin.testing.ArtifactStubFactory; import org.apache.maven.plugin.testing.stubs.MavenProjectStub; import org.apache.maven.plugins.surefire.report.stubs.DependencyArtifactStubFactory; +import org.apache.maven.project.MavenProject; import org.apache.maven.shared.utils.io.FileUtils; import org.eclipse.aether.DefaultRepositorySystemSession; import org.eclipse.aether.internal.impl.SimpleLocalRepositoryManagerFactory; @@ -42,31 +45,23 @@ import static org.hamcrest.MatcherAssert.assertThat; * @author <a href="mailto:arami...@apache.org">Allan Ramirez</a> */ @SuppressWarnings("checkstyle:linelength") -public class SurefireReportMojoTest extends AbstractMojoTestCase { +public class SurefireReportTest extends AbstractMojoTestCase { private ArtifactStubFactory artifactStubFactory; - // Can be removed with Doxia 2.0.0 - private Locale origLocale; - @Override protected void setUp() throws Exception { super.setUp(); artifactStubFactory = new DependencyArtifactStubFactory(getTestFile("target"), true, false); artifactStubFactory.getWorkingDir().mkdirs(); - - origLocale = Locale.getDefault(); - Locale.setDefault(Locale.ROOT); } - @Override - protected void tearDown() throws Exception { - Locale.setDefault(origLocale); - super.tearDown(); + protected File getPluginXmlFile(String projectDirName) { + return new File(getBasedir(), "src/test/resources/unit/" + projectDirName + "/plugin-config.xml"); } protected SurefireReportMojo createReportMojo(File pluginXmlFile) throws Exception { SurefireReportMojo mojo = (SurefireReportMojo) lookupMojo("report", pluginXmlFile); - assertNotNull("Mojo found.", mojo); + assertNotNull("Mojo not found.", mojo); LegacySupport legacySupport = lookup(LegacySupport.class); legacySupport.setSession(newMavenSession(new MavenProjectStub())); @@ -75,18 +70,26 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { repoSession.setLocalRepositoryManager(new SimpleLocalRepositoryManagerFactory() .newInstance(repoSession, new LocalRepository(artifactStubFactory.getWorkingDir()))); - // setVariableValueToObject( mojo, "session", legacySupport.getSession() ); - setVariableValueToObject(mojo, "remoteRepositories", mojo.getProject().getRemoteArtifactRepositories()); + List<MavenProject> reactorProjects = + mojo.getReactorProjects() != null ? mojo.getReactorProjects() : Collections.emptyList(); + + setVariableValueToObject(mojo, "mojoExecution", getMockMojoExecution()); + // setVariableValueToObject(mojo, "session", legacySupport.getSession()); + setVariableValueToObject(mojo, "repoSession", legacySupport.getRepositorySession()); + setVariableValueToObject(mojo, "reactorProjects", reactorProjects); + setVariableValueToObject( + mojo, "remoteProjectRepositories", mojo.getProject().getRemoteProjectRepositories()); + setVariableValueToObject( + mojo, "siteDirectory", new File(mojo.getProject().getBasedir(), "src/site")); return mojo; } public void testBasicSurefireReport() throws Exception { - File testPom = new File(getUnitBaseDir(), "basic-surefire-report-test/plugin-config.xml"); + File testPom = getPluginXmlFile("basic-surefire-report-test"); SurefireReportMojo mojo = createReportMojo(testPom); File outputDir = (File) getVariableValueFromObject(mojo, "outputDirectory"); boolean showSuccess = (Boolean) getVariableValueFromObject(mojo, "showSuccess"); File reportsDir = (File) getVariableValueFromObject(mojo, "reportsDirectory"); - String outputName = (String) getVariableValueFromObject(mojo, "outputName"); File xrefLocation = (File) getVariableValueFromObject(mojo, "xrefLocation"); boolean linkXRef = (Boolean) getVariableValueFromObject(mojo, "linkXRef"); @@ -96,7 +99,6 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { new File(getBasedir() + "/src/test/resources/unit/basic-surefire-report-test/surefire-reports") .getAbsolutePath(), reportsDir.getAbsolutePath()); - assertEquals("surefire-report", outputName); assertEquals( new File(getBasedir() + "/target/site/unit/basic-surefire-report-test/xref-test").getAbsolutePath(), xrefLocation.getAbsolutePath()); @@ -111,14 +113,24 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { assertTrue(idx >= 0); } - private File getUnitBaseDir() throws UnsupportedEncodingException { - URL resource = getClass().getResource("/unit"); - // URLDecoder.decode necessary for JDK 1.5+, where spaces are escaped to %20 - return new File(URLDecoder.decode(resource.getPath(), "UTF-8")).getAbsoluteFile(); + private MojoExecution getMockMojoExecution() { + MojoDescriptor md = new MojoDescriptor(); + md.setGoal("report"); + + MojoExecution me = new MojoExecution(md); + + PluginDescriptor pd = new PluginDescriptor(); + Plugin p = new Plugin(); + p.setGroupId("org.apache.maven.plugins"); + p.setArtifactId("maven-surefire-report-plugin"); + pd.setPlugin(p); + md.setPluginDescriptor(pd); + + return me; } public void testBasicSurefireReportIfShowSuccessIsFalse() throws Exception { - File testPom = new File(getUnitBaseDir(), "basic-surefire-report-success-false/plugin-config.xml"); + File testPom = getPluginXmlFile("basic-surefire-report-success-false"); SurefireReportMojo mojo = createReportMojo(testPom); boolean showSuccess = (Boolean) getVariableValueFromObject(mojo, "showSuccess"); assertFalse(showSuccess); @@ -133,7 +145,7 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { } public void testBasicSurefireReportIfLinkXrefIsFalse() throws Exception { - File testPom = new File(getUnitBaseDir(), "basic-surefire-report-linkxref-false/plugin-config.xml"); + File testPom = getPluginXmlFile("basic-surefire-report-linkxref-false"); SurefireReportMojo mojo = createReportMojo(testPom); boolean linkXRef = (Boolean) getVariableValueFromObject(mojo, "linkXRef"); assertFalse(linkXRef); @@ -148,7 +160,7 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { } public void testBasicSurefireReportIfReportingIsNull() throws Exception { - File testPom = new File(getUnitBaseDir(), "basic-surefire-report-reporting-null/plugin-config.xml"); + File testPom = getPluginXmlFile("basic-surefire-report-reporting-null"); SurefireReportMojo mojo = createReportMojo(testPom); mojo.execute(); File report = @@ -162,7 +174,7 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { @SuppressWarnings("checkstyle:methodname") public void testBasicSurefireReport_AnchorTestCases() throws Exception { - File testPom = new File(getUnitBaseDir(), "basic-surefire-report-anchor-test-cases/plugin-config.xml"); + File testPom = getPluginXmlFile("basic-surefire-report-anchor-test-cases"); SurefireReportMojo mojo = createReportMojo(testPom); mojo.execute(); File report = @@ -179,7 +191,7 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { } public void testSurefireReportSingleError() throws Exception { - File testPom = new File(getUnitBaseDir(), "surefire-report-single-error/plugin-config.xml"); + File testPom = getPluginXmlFile("surefire-report-single-error"); SurefireReportMojo mojo = createReportMojo(testPom); mojo.execute(); File report = new File(getBasedir(), "target/site/unit/surefire-report-single-error/surefire-report.html"); @@ -189,29 +201,29 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\">1</td>\n" + + "<td>1</td>\n" + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td>"))); assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\"><a href=\"#surefire\">surefire</a></td>\n" + + "<td><a href=\"#surefire\">surefire</a></td>\n" + "<td>1</td>\n" + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td></tr>"))); assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\">" + + "<td>" + "<a href=\"#surefire.MyTest\">" - + "<img src=\"images/icon_error_sml.gif\" alt=\"\" />" + + "<img src=\"images/icon_error_sml.gif\" />" + "</a>" + "</td>\n" + "<td><a href=\"#surefire.MyTest\">MyTest</a></td>\n" @@ -219,7 +231,7 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td></tr>"))); assertThat(htmlContent, containsString(">surefire.MyTest:13</a>")); @@ -266,7 +278,7 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { } public void testSurefireReportNestedClassTrimStackTrace() throws Exception { - File testPom = new File(getUnitBaseDir(), "surefire-report-nestedClass-trimStackTrace/plugin-config.xml"); + File testPom = getPluginXmlFile("surefire-report-nestedClass-trimStackTrace"); SurefireReportMojo mojo = createReportMojo(testPom); mojo.execute(); File report = new File( @@ -277,29 +289,29 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\">1</td>\n" + + "<td>1</td>\n" + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td>"))); assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\"><a href=\"#surefire\">surefire</a></td>\n" + + "<td><a href=\"#surefire\">surefire</a></td>\n" + "<td>1</td>\n" + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td></tr>"))); assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\">" + + "<td>" + "<a href=\"#surefire.MyTest\">" - + "<img src=\"images/icon_error_sml.gif\" alt=\"\" />" + + "<img src=\"images/icon_error_sml.gif\" />" + "</a>" + "</td>\n" + "<td><a href=\"#surefire.MyTest\">MyTest</a></td>\n" @@ -307,7 +319,7 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td></tr>"))); assertThat(htmlContent, containsString(">surefire.MyTest:13</a>")); @@ -330,7 +342,7 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { } public void testSurefireReportNestedClass() throws Exception { - File testPom = new File(getUnitBaseDir(), "surefire-report-nestedClass/plugin-config.xml"); + File testPom = getPluginXmlFile("surefire-report-nestedClass"); SurefireReportMojo mojo = createReportMojo(testPom); mojo.execute(); File report = new File(getBasedir(), "target/site/unit/surefire-report-nestedClass/surefire-report.html"); @@ -340,29 +352,29 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\">1</td>\n" + + "<td>1</td>\n" + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td>"))); assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\"><a href=\"#surefire\">surefire</a></td>\n" + + "<td><a href=\"#surefire\">surefire</a></td>\n" + "<td>1</td>\n" + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td></tr>"))); assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\">" + + "<td>" + "<a href=\"#surefire.MyTest\">" - + "<img src=\"images/icon_error_sml.gif\" alt=\"\" />" + + "<img src=\"images/icon_error_sml.gif\" />" + "</a>" + "</td>\n" + "<td><a href=\"#surefire.MyTest\">MyTest</a></td>\n" @@ -370,7 +382,7 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td></tr>"))); assertThat(htmlContent, containsString(">surefire.MyTest:13</a>")); @@ -417,7 +429,7 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { } public void testSurefireReportEnclosedTrimStackTrace() throws Exception { - File testPom = new File(getUnitBaseDir(), "surefire-report-enclosed-trimStackTrace/plugin-config.xml"); + File testPom = getPluginXmlFile("surefire-report-enclosed-trimStackTrace"); SurefireReportMojo mojo = createReportMojo(testPom); mojo.execute(); File report = @@ -428,29 +440,29 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\">1</td>\n" + + "<td>1</td>\n" + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td>"))); assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\"><a href=\"#surefire\">surefire</a></td>\n" + + "<td><a href=\"#surefire\">surefire</a></td>\n" + "<td>1</td>\n" + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td></tr>"))); assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\">" + + "<td>" + "<a href=\"#surefire.MyTest$A\">" - + "<img src=\"images/icon_error_sml.gif\" alt=\"\" />" + + "<img src=\"images/icon_error_sml.gif\" />" + "</a>" + "</td>\n" + "<td><a href=\"#surefire.MyTest$A\">MyTest$A</a></td>\n" @@ -458,7 +470,7 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td></tr>"))); assertThat(htmlContent, containsString(">surefire.MyTest$A:45</a>")); @@ -481,7 +493,7 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { } public void testSurefireReportEnclosed() throws Exception { - File testPom = new File(getUnitBaseDir(), "surefire-report-enclosed/plugin-config.xml"); + File testPom = getPluginXmlFile("surefire-report-enclosed"); SurefireReportMojo mojo = createReportMojo(testPom); mojo.execute(); File report = new File(getBasedir(), "target/site/unit/surefire-report-enclosed/surefire-report.html"); @@ -491,29 +503,29 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\">1</td>\n" + + "<td>1</td>\n" + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td>"))); assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\"><a href=\"#surefire\">surefire</a></td>\n" + + "<td><a href=\"#surefire\">surefire</a></td>\n" + "<td>1</td>\n" + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td></tr>"))); assertThat( htmlContent, containsString(toSystemNewLine("<tr class=\"b\">\n" - + "<td align=\"left\">" + + "<td>" + "<a href=\"#surefire.MyTest$A\">" - + "<img src=\"images/icon_error_sml.gif\" alt=\"\" />" + + "<img src=\"images/icon_error_sml.gif\" />" + "</a>" + "</td>\n" + "<td><a href=\"#surefire.MyTest$A\">MyTest$A</a></td>\n" @@ -521,7 +533,7 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { + "<td>1</td>\n" + "<td>0</td>\n" + "<td>0</td>\n" - + "<td>0.0%</td>\n" + + "<td>0%</td>\n" + "<td>0 s</td></tr>"))); assertThat(htmlContent, containsString(">surefire.MyTest$A:45</a>")); @@ -578,7 +590,7 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { } public void testCustomTitleAndDescriptionReport() throws Exception { - File testPom = new File(getUnitBaseDir(), "surefire-1183/plugin-config.xml"); + File testPom = getPluginXmlFile("surefire-1183"); SurefireReportMojo mojo = createReportMojo(testPom); File outputDir = (File) getVariableValueFromObject(mojo, "outputDirectory"); @@ -599,6 +611,8 @@ public class SurefireReportMojoTest extends AbstractMojoTestCase { assertTrue(report.exists()); String htmlContent = FileUtils.fileRead(report); - assertTrue(htmlContent.contains("<h2><a name=\"Acceptance_Test\"></a>Acceptance Test</h2></section>")); + assertThat( + htmlContent, + containsString(toSystemNewLine("<section><a id=\"Acceptance_Test\"></a>\n<h1>Acceptance Test</h1>"))); } } diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/AnchorTestCasesStub.java similarity index 67% copy from maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java copy to maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/AnchorTestCasesStub.java index 9365879e4..3b69f4ba8 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/AnchorTestCasesStub.java @@ -18,21 +18,10 @@ */ package org.apache.maven.plugins.surefire.report.stubs; -import java.util.ArrayList; -import java.util.List; +public class AnchorTestCasesStub extends SurefireReportMavenProjectStub { -import org.apache.maven.model.ReportPlugin; -import org.apache.maven.plugin.testing.stubs.MavenProjectStub; - -/** - * @author <a href="mailto:arami...@apache.org">Allan Ramirez</a> - */ -public class SurefireRepMavenProjectStub2 extends MavenProjectStub { - /** - * {@inheritDoc} - */ @Override - public List<ReportPlugin> getReportPlugins() { - return new ArrayList<>(); + protected String getProjectDirName() { + return "basic-surefire-report-anchor-test-cases"; } } diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/DependencyArtifactStubFactory.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/DependencyArtifactStubFactory.java index 01c383f45..06f9900ed 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/DependencyArtifactStubFactory.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/DependencyArtifactStubFactory.java @@ -18,25 +18,6 @@ */ package org.apache.maven.plugins.surefire.report.stubs; -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - import java.io.File; import java.io.IOException; @@ -45,10 +26,6 @@ import org.apache.maven.artifact.ArtifactUtils; import org.apache.maven.artifact.versioning.VersionRange; import org.apache.maven.plugin.testing.ArtifactStubFactory; -/** - * DependencyArtifactStubFactory - * - */ public class DependencyArtifactStubFactory extends ArtifactStubFactory { private boolean flattenedPath = true; diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/EnclosedStub.java similarity index 67% copy from maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java copy to maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/EnclosedStub.java index 9365879e4..bdcce6b04 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/EnclosedStub.java @@ -18,21 +18,10 @@ */ package org.apache.maven.plugins.surefire.report.stubs; -import java.util.ArrayList; -import java.util.List; +public class EnclosedStub extends SurefireReportMavenProjectStub { -import org.apache.maven.model.ReportPlugin; -import org.apache.maven.plugin.testing.stubs.MavenProjectStub; - -/** - * @author <a href="mailto:arami...@apache.org">Allan Ramirez</a> - */ -public class SurefireRepMavenProjectStub2 extends MavenProjectStub { - /** - * {@inheritDoc} - */ @Override - public List<ReportPlugin> getReportPlugins() { - return new ArrayList<>(); + protected String getProjectDirName() { + return "surefire-report-enclosed"; } } diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/EnclosedTrimStackTraceStub.java similarity index 67% copy from maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java copy to maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/EnclosedTrimStackTraceStub.java index 9365879e4..f5ba0e74b 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/EnclosedTrimStackTraceStub.java @@ -18,21 +18,10 @@ */ package org.apache.maven.plugins.surefire.report.stubs; -import java.util.ArrayList; -import java.util.List; +public class EnclosedTrimStackTraceStub extends SurefireReportMavenProjectStub { -import org.apache.maven.model.ReportPlugin; -import org.apache.maven.plugin.testing.stubs.MavenProjectStub; - -/** - * @author <a href="mailto:arami...@apache.org">Allan Ramirez</a> - */ -public class SurefireRepMavenProjectStub2 extends MavenProjectStub { - /** - * {@inheritDoc} - */ @Override - public List<ReportPlugin> getReportPlugins() { - return new ArrayList<>(); + protected String getProjectDirName() { + return "surefire-report-enclosed-trimStackTrace"; } } diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/LinkXrefFalseStub.java similarity index 67% copy from maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java copy to maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/LinkXrefFalseStub.java index 9365879e4..7bf7cf44b 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/LinkXrefFalseStub.java @@ -18,21 +18,10 @@ */ package org.apache.maven.plugins.surefire.report.stubs; -import java.util.ArrayList; -import java.util.List; +public class LinkXrefFalseStub extends SurefireReportMavenProjectStub { -import org.apache.maven.model.ReportPlugin; -import org.apache.maven.plugin.testing.stubs.MavenProjectStub; - -/** - * @author <a href="mailto:arami...@apache.org">Allan Ramirez</a> - */ -public class SurefireRepMavenProjectStub2 extends MavenProjectStub { - /** - * {@inheritDoc} - */ @Override - public List<ReportPlugin> getReportPlugins() { - return new ArrayList<>(); + protected String getProjectDirName() { + return "basic-surefire-report-linkxref-false"; } } diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/NestedClassStub.java similarity index 67% copy from maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java copy to maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/NestedClassStub.java index 9365879e4..6f1547b37 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/NestedClassStub.java @@ -18,21 +18,10 @@ */ package org.apache.maven.plugins.surefire.report.stubs; -import java.util.ArrayList; -import java.util.List; +public class NestedClassStub extends SurefireReportMavenProjectStub { -import org.apache.maven.model.ReportPlugin; -import org.apache.maven.plugin.testing.stubs.MavenProjectStub; - -/** - * @author <a href="mailto:arami...@apache.org">Allan Ramirez</a> - */ -public class SurefireRepMavenProjectStub2 extends MavenProjectStub { - /** - * {@inheritDoc} - */ @Override - public List<ReportPlugin> getReportPlugins() { - return new ArrayList<>(); + protected String getProjectDirName() { + return "surefire-report-nestedClass"; } } diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/NestedClassTrimStackTraceStub.java similarity index 67% copy from maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java copy to maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/NestedClassTrimStackTraceStub.java index 9365879e4..1a30076f5 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/NestedClassTrimStackTraceStub.java @@ -18,21 +18,10 @@ */ package org.apache.maven.plugins.surefire.report.stubs; -import java.util.ArrayList; -import java.util.List; +public class NestedClassTrimStackTraceStub extends SurefireReportMavenProjectStub { -import org.apache.maven.model.ReportPlugin; -import org.apache.maven.plugin.testing.stubs.MavenProjectStub; - -/** - * @author <a href="mailto:arami...@apache.org">Allan Ramirez</a> - */ -public class SurefireRepMavenProjectStub2 extends MavenProjectStub { - /** - * {@inheritDoc} - */ @Override - public List<ReportPlugin> getReportPlugins() { - return new ArrayList<>(); + protected String getProjectDirName() { + return "surefire-report-nestedClass-trimStackTrace"; } } diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/ReportTestStub.java similarity index 68% copy from maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java copy to maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/ReportTestStub.java index 9365879e4..d04125a72 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/ReportTestStub.java @@ -18,21 +18,10 @@ */ package org.apache.maven.plugins.surefire.report.stubs; -import java.util.ArrayList; -import java.util.List; +public class ReportTestStub extends SurefireReportMavenProjectStub { -import org.apache.maven.model.ReportPlugin; -import org.apache.maven.plugin.testing.stubs.MavenProjectStub; - -/** - * @author <a href="mailto:arami...@apache.org">Allan Ramirez</a> - */ -public class SurefireRepMavenProjectStub2 extends MavenProjectStub { - /** - * {@inheritDoc} - */ @Override - public List<ReportPlugin> getReportPlugins() { - return new ArrayList<>(); + protected String getProjectDirName() { + return "basic-surefire-report-test"; } } diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/ReportingNullStub.java similarity index 86% copy from maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java copy to maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/ReportingNullStub.java index 9365879e4..86b557ab0 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/ReportingNullStub.java @@ -22,12 +22,11 @@ import java.util.ArrayList; import java.util.List; import org.apache.maven.model.ReportPlugin; -import org.apache.maven.plugin.testing.stubs.MavenProjectStub; /** * @author <a href="mailto:arami...@apache.org">Allan Ramirez</a> */ -public class SurefireRepMavenProjectStub2 extends MavenProjectStub { +public class ReportingNullStub extends SurefireReportMavenProjectStub { /** * {@inheritDoc} */ @@ -35,4 +34,9 @@ public class SurefireRepMavenProjectStub2 extends MavenProjectStub { public List<ReportPlugin> getReportPlugins() { return new ArrayList<>(); } + + @Override + protected String getProjectDirName() { + return "basic-surefire-report-reporting-null"; + } } diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SingleErrorStub.java similarity index 67% copy from maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java copy to maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SingleErrorStub.java index 9365879e4..60e83182e 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SingleErrorStub.java @@ -18,21 +18,10 @@ */ package org.apache.maven.plugins.surefire.report.stubs; -import java.util.ArrayList; -import java.util.List; +public class SingleErrorStub extends SurefireReportMavenProjectStub { -import org.apache.maven.model.ReportPlugin; -import org.apache.maven.plugin.testing.stubs.MavenProjectStub; - -/** - * @author <a href="mailto:arami...@apache.org">Allan Ramirez</a> - */ -public class SurefireRepMavenProjectStub2 extends MavenProjectStub { - /** - * {@inheritDoc} - */ @Override - public List<ReportPlugin> getReportPlugins() { - return new ArrayList<>(); + protected String getProjectDirName() { + return "surefire-report-single-error"; } } diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SuccessFalseStub.java similarity index 67% copy from maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java copy to maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SuccessFalseStub.java index 9365879e4..afe355951 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SuccessFalseStub.java @@ -18,21 +18,10 @@ */ package org.apache.maven.plugins.surefire.report.stubs; -import java.util.ArrayList; -import java.util.List; +public class SuccessFalseStub extends SurefireReportMavenProjectStub { -import org.apache.maven.model.ReportPlugin; -import org.apache.maven.plugin.testing.stubs.MavenProjectStub; - -/** - * @author <a href="mailto:arami...@apache.org">Allan Ramirez</a> - */ -public class SurefireRepMavenProjectStub2 extends MavenProjectStub { - /** - * {@inheritDoc} - */ @Override - public List<ReportPlugin> getReportPlugins() { - return new ArrayList<>(); + protected String getProjectDirName() { + return "basic-surefire-report-success-false"; } } diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/Surefire1183Stub.java similarity index 67% rename from maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java rename to maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/Surefire1183Stub.java index 9365879e4..e39849618 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub2.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/Surefire1183Stub.java @@ -18,21 +18,10 @@ */ package org.apache.maven.plugins.surefire.report.stubs; -import java.util.ArrayList; -import java.util.List; +public class Surefire1183Stub extends SurefireReportMavenProjectStub { -import org.apache.maven.model.ReportPlugin; -import org.apache.maven.plugin.testing.stubs.MavenProjectStub; - -/** - * @author <a href="mailto:arami...@apache.org">Allan Ramirez</a> - */ -public class SurefireRepMavenProjectStub2 extends MavenProjectStub { - /** - * {@inheritDoc} - */ @Override - public List<ReportPlugin> getReportPlugins() { - return new ArrayList<>(); + protected String getProjectDirName() { + return "surefire-1183"; } } diff --git a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub.java b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireReportMavenProjectStub.java similarity index 77% rename from maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub.java rename to maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireReportMavenProjectStub.java index bd4497c24..17b2a9566 100644 --- a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireRepMavenProjectStub.java +++ b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/stubs/SurefireReportMavenProjectStub.java @@ -18,22 +18,37 @@ */ package org.apache.maven.plugins.surefire.report.stubs; +import java.io.File; import java.util.Collections; import java.util.List; +import org.apache.maven.RepositoryUtils; import org.apache.maven.artifact.repository.ArtifactRepository; import org.apache.maven.artifact.repository.ArtifactRepositoryPolicy; import org.apache.maven.artifact.repository.MavenArtifactRepository; import org.apache.maven.artifact.repository.layout.DefaultRepositoryLayout; -import org.apache.maven.model.Model; import org.apache.maven.model.ReportPlugin; import org.apache.maven.model.Reporting; import org.apache.maven.plugin.testing.stubs.MavenProjectStub; +import org.eclipse.aether.repository.RemoteRepository; /** * @author <a href="mailto:arami...@apache.org">Allan Ramirez</a> */ -public class SurefireRepMavenProjectStub extends MavenProjectStub { +public abstract class SurefireReportMavenProjectStub extends MavenProjectStub { + + protected abstract String getProjectDirName(); + + @Override + public File getBasedir() { + return new File(super.getBasedir() + "/src/test/resources/unit/" + getProjectDirName()); + } + + @Override + public File getFile() { + return new File(getBasedir(), "plugin-config.xml"); + } + /** * {@inheritDoc} */ @@ -47,10 +62,6 @@ public class SurefireRepMavenProjectStub extends MavenProjectStub { reportPlugin.setVersion("2.0-SNAPSHOT"); reporting.addPlugin(reportPlugin); - Model model = new Model(); - - model.setReporting(reporting); - return reporting.getPlugins(); } @@ -65,4 +76,9 @@ public class SurefireRepMavenProjectStub extends MavenProjectStub { return Collections.singletonList(repository); } + + @Override + public List<RemoteRepository> getRemoteProjectRepositories() { + return RepositoryUtils.toRepos(getRemoteArtifactRepositories()); + } } diff --git a/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-anchor-test-cases/plugin-config.xml b/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-anchor-test-cases/plugin-config.xml index 3045dce6d..fe0e78d7f 100644 --- a/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-anchor-test-cases/plugin-config.xml +++ b/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-anchor-test-cases/plugin-config.xml @@ -24,8 +24,7 @@ <artifactId>maven-surefire-report-plugin</artifactId> <configuration> <outputDirectory>${basedir}/target/site/unit/basic-surefire-report-anchor-test-cases</outputDirectory> - <localRepository>${localRepository}</localRepository> - <project implementation="org.apache.maven.plugins.surefire.report.stubs.SurefireRepMavenProjectStub"/> + <project implementation="org.apache.maven.plugins.surefire.report.stubs.AnchorTestCasesStub"/> <showSuccess>true</showSuccess> <reportsDirectory>${basedir}/src/test/resources/unit/basic-surefire-report-anchor-test-cases/surefire-reports </reportsDirectory> diff --git a/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-linkxref-false/plugin-config.xml b/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-linkxref-false/plugin-config.xml index e0586aad1..01f10b34a 100644 --- a/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-linkxref-false/plugin-config.xml +++ b/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-linkxref-false/plugin-config.xml @@ -24,8 +24,7 @@ <artifactId>maven-surefire-report-plugin</artifactId> <configuration> <outputDirectory>${basedir}/target/site/unit/basic-surefire-report-linkxref-false</outputDirectory> - <localRepository>${localRepository}</localRepository> - <project implementation="org.apache.maven.plugins.surefire.report.stubs.SurefireRepMavenProjectStub"/> + <project implementation="org.apache.maven.plugins.surefire.report.stubs.LinkXrefFalseStub"/> <showSuccess>true</showSuccess> <reportsDirectory>${basedir}/src/test/resources/unit/basic-surefire-report-linkxref-false/surefire-reports </reportsDirectory> diff --git a/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-reporting-null/plugin-config.xml b/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-reporting-null/plugin-config.xml index 8aca877bd..f53e5dfea 100644 --- a/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-reporting-null/plugin-config.xml +++ b/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-reporting-null/plugin-config.xml @@ -24,8 +24,7 @@ <artifactId>maven-surefire-report-plugin</artifactId> <configuration> <outputDirectory>${basedir}/target/site/unit/basic-surefire-report-reporting-null</outputDirectory> - <localRepository>${localRepository}</localRepository> - <project implementation="org.apache.maven.plugins.surefire.report.stubs.SurefireRepMavenProjectStub2"/> + <project implementation="org.apache.maven.plugins.surefire.report.stubs.ReportingNullStub"/> <showSuccess>true</showSuccess> <reportsDirectory>${basedir}/src/test/resources/unit/basic-surefire-report-reporting-null/surefire-reports </reportsDirectory> diff --git a/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-success-false/plugin-config.xml b/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-success-false/plugin-config.xml index c79859112..27d6b2e38 100644 --- a/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-success-false/plugin-config.xml +++ b/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-success-false/plugin-config.xml @@ -24,8 +24,7 @@ <artifactId>maven-surefire-report-plugin</artifactId> <configuration> <outputDirectory>${basedir}/target/site/unit/basic-surefire-report-success-false</outputDirectory> - <localRepository>${localRepository}</localRepository> - <project implementation="org.apache.maven.plugins.surefire.report.stubs.SurefireRepMavenProjectStub"/> + <project implementation="org.apache.maven.plugins.surefire.report.stubs.SuccessFalseStub"/> <showSuccess>false</showSuccess> <reportsDirectory>${basedir}/src/test/resources/unit/basic-surefire-report-success-false/surefire-reports </reportsDirectory> diff --git a/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-test/plugin-config.xml b/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-test/plugin-config.xml index 81e59caf1..782c972c8 100644 --- a/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-test/plugin-config.xml +++ b/maven-surefire-report-plugin/src/test/resources/unit/basic-surefire-report-test/plugin-config.xml @@ -24,8 +24,7 @@ <artifactId>maven-surefire-report-plugin</artifactId> <configuration> <outputDirectory>${basedir}/target/site/unit/basic-surefire-report-test</outputDirectory> - <localRepository>${localRepository}</localRepository> - <project implementation="org.apache.maven.plugins.surefire.report.stubs.SurefireRepMavenProjectStub"/> + <project implementation="org.apache.maven.plugins.surefire.report.stubs.ReportTestStub"/> <showSuccess>true</showSuccess> <reportsDirectory>${basedir}/src/test/resources/unit/basic-surefire-report-test/surefire-reports </reportsDirectory> diff --git a/maven-surefire-report-plugin/src/test/resources/unit/surefire-1183/plugin-config.xml b/maven-surefire-report-plugin/src/test/resources/unit/surefire-1183/plugin-config.xml index 108f58350..c3a82a688 100644 --- a/maven-surefire-report-plugin/src/test/resources/unit/surefire-1183/plugin-config.xml +++ b/maven-surefire-report-plugin/src/test/resources/unit/surefire-1183/plugin-config.xml @@ -25,9 +25,8 @@ <artifactId>maven-surefire-report-plugin</artifactId> <configuration> <project - implementation="org.apache.maven.plugins.surefire.report.stubs.SurefireRepMavenProjectStub"/> + implementation="org.apache.maven.plugins.surefire.report.stubs.Surefire1183Stub"/> <outputName>acceptance-test-report</outputName> - <localRepository>${localRepository}</localRepository> <customBundle>${basedir}/src/test/resources/unit/surefire-1183/src/site/custom/surefire-report.properties</customBundle> <outputDirectory>${basedir}/target/site/unit/surefire-1183</outputDirectory> <reportsDirectory>${basedir}/src/test/resources/unit/surefire-1183/acceptancetest-reports</reportsDirectory> diff --git a/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-enclosed-trimStackTrace/plugin-config.xml b/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-enclosed-trimStackTrace/plugin-config.xml index 981bb1882..d02fe60da 100644 --- a/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-enclosed-trimStackTrace/plugin-config.xml +++ b/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-enclosed-trimStackTrace/plugin-config.xml @@ -24,8 +24,7 @@ <artifactId>maven-surefire-report-plugin</artifactId> <configuration> <outputDirectory>${basedir}/target/site/unit/surefire-report-enclosed-trimStackTrace</outputDirectory> - <localRepository>${localRepository}</localRepository> - <project implementation="org.apache.maven.plugins.surefire.report.stubs.SurefireRepMavenProjectStub"/> + <project implementation="org.apache.maven.plugins.surefire.report.stubs.EnclosedTrimStackTraceStub"/> <showSuccess>true</showSuccess> <reportsDirectory>${basedir}/src/test/resources/unit/surefire-report-enclosed-trimStackTrace/surefire-reports </reportsDirectory> diff --git a/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-enclosed/plugin-config.xml b/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-enclosed/plugin-config.xml index 26bae34ab..5bb6b5ab6 100644 --- a/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-enclosed/plugin-config.xml +++ b/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-enclosed/plugin-config.xml @@ -24,8 +24,7 @@ <artifactId>maven-surefire-report-plugin</artifactId> <configuration> <outputDirectory>${basedir}/target/site/unit/surefire-report-enclosed</outputDirectory> - <localRepository>${localRepository}</localRepository> - <project implementation="org.apache.maven.plugins.surefire.report.stubs.SurefireRepMavenProjectStub"/> + <project implementation="org.apache.maven.plugins.surefire.report.stubs.EnclosedStub"/> <showSuccess>true</showSuccess> <reportsDirectory>${basedir}/src/test/resources/unit/surefire-report-enclosed/surefire-reports </reportsDirectory> diff --git a/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-nestedClass-trimStackTrace/plugin-config.xml b/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-nestedClass-trimStackTrace/plugin-config.xml index dcf6a9a72..7e6c0a506 100644 --- a/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-nestedClass-trimStackTrace/plugin-config.xml +++ b/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-nestedClass-trimStackTrace/plugin-config.xml @@ -24,8 +24,7 @@ <artifactId>maven-surefire-report-plugin</artifactId> <configuration> <outputDirectory>${basedir}/target/site/unit/surefire-report-nestedClass-trimStackTrace</outputDirectory> - <localRepository>${localRepository}</localRepository> - <project implementation="org.apache.maven.plugins.surefire.report.stubs.SurefireRepMavenProjectStub"/> + <project implementation="org.apache.maven.plugins.surefire.report.stubs.NestedClassTrimStackTraceStub"/> <showSuccess>true</showSuccess> <reportsDirectory>${basedir}/src/test/resources/unit/surefire-report-nestedClass-trimStackTrace/surefire-reports </reportsDirectory> diff --git a/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-nestedClass/plugin-config.xml b/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-nestedClass/plugin-config.xml index 86ff4639b..5b577227c 100644 --- a/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-nestedClass/plugin-config.xml +++ b/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-nestedClass/plugin-config.xml @@ -24,8 +24,7 @@ <artifactId>maven-surefire-report-plugin</artifactId> <configuration> <outputDirectory>${basedir}/target/site/unit/surefire-report-nestedClass</outputDirectory> - <localRepository>${localRepository}</localRepository> - <project implementation="org.apache.maven.plugins.surefire.report.stubs.SurefireRepMavenProjectStub"/> + <project implementation="org.apache.maven.plugins.surefire.report.stubs.NestedClassStub"/> <showSuccess>true</showSuccess> <reportsDirectory>${basedir}/src/test/resources/unit/surefire-report-nestedClass/surefire-reports </reportsDirectory> diff --git a/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-single-error/plugin-config.xml b/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-single-error/plugin-config.xml index e8a3f5889..cfb5505a2 100644 --- a/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-single-error/plugin-config.xml +++ b/maven-surefire-report-plugin/src/test/resources/unit/surefire-report-single-error/plugin-config.xml @@ -24,8 +24,7 @@ <artifactId>maven-surefire-report-plugin</artifactId> <configuration> <outputDirectory>${basedir}/target/site/unit/surefire-report-single-error</outputDirectory> - <localRepository>${localRepository}</localRepository> - <project implementation="org.apache.maven.plugins.surefire.report.stubs.SurefireRepMavenProjectStub"/> + <project implementation="org.apache.maven.plugins.surefire.report.stubs.SingleErrorStub"/> <showSuccess>true</showSuccess> <reportsDirectory>${basedir}/src/test/resources/unit/surefire-report-single-error/surefire-reports </reportsDirectory> diff --git a/pom.xml b/pom.xml index 525d3085f..a9dbdaf0e 100644 --- a/pom.xml +++ b/pom.xml @@ -15,7 +15,7 @@ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY ~ KIND, either express or implied. See the License for the ~ specific language governing permissions and limitations - ~ under the License. + ~ under the License. --> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> <modelVersion>4.0.0</modelVersion> @@ -28,7 +28,7 @@ <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> <packaging>pom</packaging> <name>Apache Maven Surefire</name> @@ -104,7 +104,7 @@ <maven.compiler.testTarget>1.${javaVersion}</maven.compiler.testTarget> <jvm9ArgsTests /> <jvm.args.tests>${jvm9ArgsTests} -Xms32m -Xmx144m -XX:SoftRefLRUPolicyMSPerMB=50 -Djava.awt.headless=true -Djdk.net.URLClassPath.disableClassPathURLCheck=true</jvm.args.tests> - <project.build.outputTimestamp>2023-05-05T20:48:43Z</project.build.outputTimestamp> + <project.build.outputTimestamp>2023-05-07T15:32:06Z</project.build.outputTimestamp> </properties> <dependencyManagement> @@ -124,11 +124,6 @@ <artifactId>commons-io</artifactId> <version>${commonsIoVersion}</version> </dependency> - <dependency> - <groupId>org.apache.maven.reporting</groupId> - <artifactId>maven-reporting-api</artifactId> - <version>3.1.1</version> - </dependency> <dependency> <groupId>org.apache.maven</groupId> <artifactId>maven-core</artifactId> @@ -167,21 +162,6 @@ <artifactId>maven-shared-utils</artifactId> <version>${mavenSharedUtilsVersion}</version> </dependency> - <dependency> - <groupId>org.apache.maven.reporting</groupId> - <artifactId>maven-reporting-impl</artifactId> - <version>3.2.0</version> - <exclusions> - <exclusion> - <groupId>org.apache.maven</groupId> - <artifactId>maven-core</artifactId> - </exclusion> - <exclusion> - <groupId>org.apache.maven</groupId> - <artifactId>maven-plugin-api</artifactId> - </exclusion> - </exclusions> - </dependency> <dependency> <groupId>org.apache.maven.shared</groupId> <artifactId>maven-common-artifact-filters</artifactId> diff --git a/surefire-api/pom.xml b/surefire-api/pom.xml index ad6bd587b..a96fb7ed7 100644 --- a/surefire-api/pom.xml +++ b/surefire-api/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-api</artifactId> diff --git a/surefire-booter/pom.xml b/surefire-booter/pom.xml index 4eb498736..e70f4aae9 100644 --- a/surefire-booter/pom.xml +++ b/surefire-booter/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-booter</artifactId> diff --git a/surefire-extensions-api/pom.xml b/surefire-extensions-api/pom.xml index d73038fe6..73f3f1e99 100644 --- a/surefire-extensions-api/pom.xml +++ b/surefire-extensions-api/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-extensions-api</artifactId> diff --git a/surefire-extensions-spi/pom.xml b/surefire-extensions-spi/pom.xml index cab3a9fbb..2c6b2ea0c 100644 --- a/surefire-extensions-spi/pom.xml +++ b/surefire-extensions-spi/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-extensions-spi</artifactId> diff --git a/surefire-grouper/pom.xml b/surefire-grouper/pom.xml index d4372aeb9..5ea0bcd54 100644 --- a/surefire-grouper/pom.xml +++ b/surefire-grouper/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-grouper</artifactId> diff --git a/surefire-its/pom.xml b/surefire-its/pom.xml index 4062c7403..5a3fda905 100644 --- a/surefire-its/pom.xml +++ b/surefire-its/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-its</artifactId> diff --git a/surefire-its/src/test/resources/surefire-260-testWithIdenticalNames/pom.xml b/surefire-its/src/test/resources/surefire-260-testWithIdenticalNames/pom.xml index 4bb71da60..54c809278 100644 --- a/surefire-its/src/test/resources/surefire-260-testWithIdenticalNames/pom.xml +++ b/surefire-its/src/test/resources/surefire-260-testWithIdenticalNames/pom.xml @@ -57,7 +57,7 @@ <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-site-plugin</artifactId> - <version>3.7.1</version> + <version>4.0.0-M8</version> </plugin> </plugins> </build> @@ -67,7 +67,7 @@ <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-project-info-reports-plugin</artifactId> - <version>3.0.0</version> + <version>4.0.0-M1-SNAPSHOT</version> <configuration> <dependencyLocationsEnabled>false</dependencyLocationsEnabled> </configuration> diff --git a/surefire-logger-api/pom.xml b/surefire-logger-api/pom.xml index 6d8ba2542..18ceb7fcf 100644 --- a/surefire-logger-api/pom.xml +++ b/surefire-logger-api/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-logger-api</artifactId> diff --git a/surefire-providers/common-java5/pom.xml b/surefire-providers/common-java5/pom.xml index 9354a9c9e..6414ac4d9 100644 --- a/surefire-providers/common-java5/pom.xml +++ b/surefire-providers/common-java5/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire-providers</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>common-java5</artifactId> diff --git a/surefire-providers/common-junit3/pom.xml b/surefire-providers/common-junit3/pom.xml index 73e9717cd..c73ebc221 100644 --- a/surefire-providers/common-junit3/pom.xml +++ b/surefire-providers/common-junit3/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire-providers</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>common-junit3</artifactId> diff --git a/surefire-providers/common-junit4/pom.xml b/surefire-providers/common-junit4/pom.xml index 65030e4e3..9c3339ade 100644 --- a/surefire-providers/common-junit4/pom.xml +++ b/surefire-providers/common-junit4/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire-providers</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>common-junit4</artifactId> diff --git a/surefire-providers/common-junit48/pom.xml b/surefire-providers/common-junit48/pom.xml index 02848eeab..3bd623639 100644 --- a/surefire-providers/common-junit48/pom.xml +++ b/surefire-providers/common-junit48/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire-providers</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>common-junit48</artifactId> diff --git a/surefire-providers/pom.xml b/surefire-providers/pom.xml index cb9bc30a3..87303757b 100644 --- a/surefire-providers/pom.xml +++ b/surefire-providers/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-providers</artifactId> diff --git a/surefire-providers/surefire-junit-platform/pom.xml b/surefire-providers/surefire-junit-platform/pom.xml index a78c84822..da589edf4 100644 --- a/surefire-providers/surefire-junit-platform/pom.xml +++ b/surefire-providers/surefire-junit-platform/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire-providers</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-junit-platform</artifactId> diff --git a/surefire-providers/surefire-junit3/pom.xml b/surefire-providers/surefire-junit3/pom.xml index 797b6352a..f3818874d 100644 --- a/surefire-providers/surefire-junit3/pom.xml +++ b/surefire-providers/surefire-junit3/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire-providers</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-junit3</artifactId> diff --git a/surefire-providers/surefire-junit4/pom.xml b/surefire-providers/surefire-junit4/pom.xml index 201245d9d..6c4c99c60 100644 --- a/surefire-providers/surefire-junit4/pom.xml +++ b/surefire-providers/surefire-junit4/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire-providers</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-junit4</artifactId> diff --git a/surefire-providers/surefire-junit47/pom.xml b/surefire-providers/surefire-junit47/pom.xml index 477aeaef9..2e61865d0 100644 --- a/surefire-providers/surefire-junit47/pom.xml +++ b/surefire-providers/surefire-junit47/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire-providers</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-junit47</artifactId> diff --git a/surefire-providers/surefire-testng-utils/pom.xml b/surefire-providers/surefire-testng-utils/pom.xml index 24b292c72..ecdbb9d1e 100644 --- a/surefire-providers/surefire-testng-utils/pom.xml +++ b/surefire-providers/surefire-testng-utils/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire-providers</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-testng-utils</artifactId> diff --git a/surefire-providers/surefire-testng/pom.xml b/surefire-providers/surefire-testng/pom.xml index baab50f70..bb28ece6f 100644 --- a/surefire-providers/surefire-testng/pom.xml +++ b/surefire-providers/surefire-testng/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire-providers</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-testng</artifactId> diff --git a/surefire-report-parser/pom.xml b/surefire-report-parser/pom.xml index 557798086..0744c1de4 100644 --- a/surefire-report-parser/pom.xml +++ b/surefire-report-parser/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-report-parser</artifactId> @@ -41,10 +41,6 @@ <groupId>org.apache.maven.shared</groupId> <artifactId>maven-shared-utils</artifactId> </dependency> - <dependency> - <groupId>org.apache.maven.reporting</groupId> - <artifactId>maven-reporting-api</artifactId> - </dependency> </dependencies> <build> <plugins> diff --git a/surefire-shadefire/pom.xml b/surefire-shadefire/pom.xml index 3ef28d1c8..0c8b467e5 100644 --- a/surefire-shadefire/pom.xml +++ b/surefire-shadefire/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-shadefire</artifactId> diff --git a/surefire-shared-utils/pom.xml b/surefire-shared-utils/pom.xml index adf84aac4..e69cbdb3d 100644 --- a/surefire-shared-utils/pom.xml +++ b/surefire-shared-utils/pom.xml @@ -23,7 +23,7 @@ <parent> <groupId>org.apache.maven.surefire</groupId> <artifactId>surefire</artifactId> - <version>3.1.1-SNAPSHOT</version> + <version>3.2.0-SNAPSHOT</version> </parent> <artifactId>surefire-shared-utils</artifactId>