This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch SUREFIRE-2146
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git
commit 7e6f5fb332615181d37d7b80b2b3a89d0d4e4dfb
Author: Michael Osipov <micha...@apache.org>
AuthorDate: Thu Jan 26 19:40:11 2023 +0100
[SUREFIRE-2146] Don't draw border around reporting tables
---
.../maven/plugins/surefire/report/SurefireReportGenerator.java | 10 +++++-----
.../apache/maven/plugins/surefire/report/Surefire597Test.java | 8 ++++----
.../maven/surefire/api/testset/FundamentalFilterTest.java | 4 ++--
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git
a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
index 3d69e2ba8..c525d5b65 100644
---
a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
+++
b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
@@ -130,7 +130,7 @@ public final class SurefireReportGenerator
sink.table();
- sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, true
);
+ sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT }, false
);
sink.tableRow();
@@ -196,7 +196,7 @@ public final class SurefireReportGenerator
sink.table();
- sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT },
true );
+ sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT, LEFT },
false );
sink.tableRow();
@@ -281,7 +281,7 @@ public final class SurefireReportGenerator
{
sink.table();
- sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT,
LEFT, LEFT }, true );
+ sink.tableRows( new int[]{ LEFT, LEFT, LEFT, LEFT, LEFT, LEFT,
LEFT, LEFT }, false );
sink.tableRow();
@@ -412,7 +412,7 @@ public final class SurefireReportGenerator
{
sink.table();
- sink.tableRows( new int[]{ LEFT, LEFT, LEFT }, true );
+ sink.tableRows( new int[]{ LEFT, LEFT, LEFT }, false );
for ( ReportTestCase testCase : testCases )
{
@@ -555,7 +555,7 @@ public final class SurefireReportGenerator
sink.table();
- sink.tableRows( new int[]{ LEFT, LEFT }, true );
+ sink.tableRows( new int[]{ LEFT, LEFT }, false );
for ( ReportTestCase tCase : failures )
{
diff --git
a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java
b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java
index 95075a8ef..79d0e3068 100644
---
a/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java
+++
b/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report/Surefire597Test.java
@@ -54,7 +54,7 @@ public class Surefire597Test
gen.doGenerateReport( new SurefireReportMojo().getBundle( ENGLISH ),
sink );
String xml = writer.toString();
assertThat( xml, containsString( toSystemNewLine(
- "<table border=\"1\" class=\"bodyTable\">\n"
+ "<table border=\"0\" class=\"bodyTable\">\n"
+ "<tr class=\"a\">\n"
+ "<th>Tests</th>\n"
+ "<th>Errors</th>\n"
@@ -72,7 +72,7 @@ public class Surefire597Test
+ "</tr>"
+ "</table>" ) ) );
assertThat( xml, containsString( toSystemNewLine(
- "<table border=\"1\" class=\"bodyTable\">\n"
+ "<table border=\"0\" class=\"bodyTable\">\n"
+ "<tr class=\"a\">\n"
+ "<th>Package</th>\n"
+ "<th>Tests</th>\n"
@@ -90,7 +90,7 @@ public class Surefire597Test
+ "<td align=\"left\">0%</td>\n"
+ "<td align=\"left\">0</td></tr></table>" ) ) );
assertThat( xml, containsString( toSystemNewLine(
- "<table border=\"1\" class=\"bodyTable\">\n"
+ "<table border=\"0\" class=\"bodyTable\">\n"
+ "<tr class=\"a\">\n"
+ "<th></th>\n"
+ "<th>Class</th>\n"
@@ -110,7 +110,7 @@ public class Surefire597Test
+ "<td align=\"left\">0%</td>\n"
+ "<td align=\"left\">0</td></tr></table>" ) ) );
assertThat( xml, containsString( toSystemNewLine(
- "<table border=\"1\" class=\"bodyTable\">\n"
+ "<table border=\"0\" class=\"bodyTable\">\n"
+ "<tr class=\"a\">\n"
+ "<td align=\"left\"><figure><img
src=\"images/icon_error_sml.gif\" alt=\"\" /></figure></td>\n"
+ "<td align=\"left\"><a
id=\"surefire.MyTest.test\"></a>test</td></tr>\n"
diff --git
a/surefire-api/src/test/java/org/apache/maven/surefire/api/testset/FundamentalFilterTest.java
b/surefire-api/src/test/java/org/apache/maven/surefire/api/testset/FundamentalFilterTest.java
index af5731012..22796073b 100644
---
a/surefire-api/src/test/java/org/apache/maven/surefire/api/testset/FundamentalFilterTest.java
+++
b/surefire-api/src/test/java/org/apache/maven/surefire/api/testset/FundamentalFilterTest.java
@@ -28,7 +28,7 @@ import static org.hamcrest.Matchers.is;
/**
* Inclusive test patters:<p>
*
- * <table cellspacing=0 border=1>
+ * <table cellspacing=0 border=0>
* <tr>
* <td style=min-width:50px> test</td>
* <td style=min-width:50px></td>
@@ -178,7 +178,7 @@ import static org.hamcrest.Matchers.is;
* <p>
* Exclusive test patters:<p>
*
- * <table cellspacing=0 border=1>
+ * <table cellspacing=0 border=0>
* <tr>
* <td style=min-width:50px> test</td>
* <td style=min-width:50px></td>
