[maven-plugin-tools] branch master updated: [MPLUGIN-452] Maven scope and module name logs at wrong level (#190)

[cstamas]

This is an automated email from the ASF dual-hosted git repository.

cstamas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-plugin-tools.git


The following commit(s) were added to refs/heads/master by this push:
     new 623622cd [MPLUGIN-452] Maven scope and module name logs at wrong level 
(#190)
623622cd is described below

commit 623622cda55e837fa3e7c1f94bc4df6ae50ea335
Author: Tamas Cservenak <ta...@cservenak.net>
AuthorDate: Thu Jan 12 22:06:39 2023 +0100

    [MPLUGIN-452] Maven scope and module name logs at wrong level (#190)
    
    Should be logged at WARN level, and not ERROR level. When Mojo logs ERROR, 
it is expected that it fails the build. And this also confuses the Verifier.
    
    ---
    
    https://issues.apache.org/jira/browse/MPLUGIN-452
---
 .../apache/maven/plugin/plugin/DescriptorGeneratorMojo.java    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java
 
b/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java
index ba836830..0002b1e9 100644
--- 
a/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java
+++ 
b/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java
@@ -301,7 +301,7 @@ public class DescriptorGeneratorMojo
                         && project.getArtifactId().toLowerCase().endsWith( 
"-plugin" )
                         && !"org.apache.maven.plugins".equals( 
project.getGroupId() ) )
         {
-            getLog().error( LS + LS + "Artifact Ids of the format 
maven-___-plugin are reserved for" + LS
+            getLog().warn( LS + LS + "Artifact Ids of the format 
maven-___-plugin are reserved for" + LS
                                 + "plugins in the Group Id 
org.apache.maven.plugins" + LS
                                 + "Please change your artifactId to the format 
___-maven-plugin" + LS
                                 + "In the future this error will break the 
build." + LS + LS );
@@ -318,7 +318,7 @@ public class DescriptorGeneratorMojo
             Set<Artifact> wrongScopedArtifacts = 
dependenciesNotInProvidedScope();
             if ( !wrongScopedArtifacts.isEmpty() )
             {
-                StringBuilder errorMessage = new StringBuilder(
+                StringBuilder message = new StringBuilder(
                     LS + LS + "Some dependencies of Maven Plugins are expected 
to be in provided scope." + LS
                         + "Please make sure that dependencies listed below 
declared in POM" + LS
                         + "have set '<scope>provided</scope>' as well." + LS + 
LS
@@ -326,11 +326,11 @@ public class DescriptorGeneratorMojo
                 );
                 for ( Artifact artifact : wrongScopedArtifacts )
                 {
-                    errorMessage.append( " * " ).append( artifact ).append( LS 
);
+                    message.append( " * " ).append( artifact ).append( LS );
                 }
-                errorMessage.append( LS ).append( LS );
+                message.append( LS ).append( LS );
 
-                getLog().error( errorMessage.toString() );
+                getLog().warn( message.toString() );
             }
         }