This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch SUREFIRE-2133
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git
commit 9f8b4b5ed7a9878c225a19fe4f746de1485b8b10
Author: Michael Osipov <micha...@apache.org>
AuthorDate: Sun Dec 11 21:19:21 2022 +0100
[SUREFIRE-2133] Make anchors start *before* the headings
This closes #582
---
.../surefire/report/SurefireReportGenerator.java | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git
a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
index b4d9d2436..efea45e31 100644
---
a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
+++
b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
@@ -120,12 +120,11 @@ public final class SurefireReportGenerator
Map<String, String> summary = report.getSummary( testSuites );
sink.section1();
+ sinkAnchor( sink, "Summary" );
sink.sectionTitle1();
sink.text( bundle.getReportLabelSummary() );
sink.sectionTitle1_();
- sinkAnchor( sink, "Summary" );
-
constructHotLinks( sink, bundle );
sinkLineBreak( sink );
@@ -187,12 +186,11 @@ public final class SurefireReportGenerator
NumberFormat numberFormat = report.getNumberFormat();
sink.section1();
+ sinkAnchor( sink, "Package_List" );
sink.sectionTitle1();
sink.text( bundle.getReportLabelPackageList() );
sink.sectionTitle1_();
- sinkAnchor( sink, "Package_List" );
-
constructHotLinks( sink, bundle );
sinkLineBreak( sink );
@@ -263,12 +261,11 @@ public final class SurefireReportGenerator
List<ReportTestSuite> testSuiteList = entry.getValue();
sink.section2();
+ sinkAnchor( sink, packageName );
sink.sectionTitle2();
sink.text( packageName );
sink.sectionTitle2_();
- sinkAnchor( sink, packageName );
-
boolean showTable = false;
for ( ReportTestSuite suite : testSuiteList )
@@ -381,12 +378,11 @@ public final class SurefireReportGenerator
NumberFormat numberFormat = report.getNumberFormat();
sink.section1();
+ sinkAnchor( sink, "Test_Cases" );
sink.sectionTitle1();
sink.text( bundle.getReportLabelTestCases() );
sink.sectionTitle1_();
- sinkAnchor( sink, "Test_Cases" );
-
constructHotLinks( sink, bundle );
for ( ReportTestSuite suite : testSuites )
@@ -396,12 +392,11 @@ public final class SurefireReportGenerator
if ( !testCases.isEmpty() )
{
sink.section2();
+ sinkAnchor( sink, suite.getPackageName() + '.' +
suite.getName() );
sink.sectionTitle2();
sink.text( suite.getName() );
sink.sectionTitle2_();
- sinkAnchor( sink, suite.getPackageName() + '.' +
suite.getName() );
-
boolean showTable = false;
for ( ReportTestCase testCase : testCases )
@@ -466,7 +461,6 @@ public final class SurefireReportGenerator
if ( !testCase.isSuccessful() )
{
sink.tableCell();
-
sinkAnchor( sink, "TC_" + toHtmlId( testCase.getFullName() ) );
sinkLink( sink, testCase.getName(), "#" + toHtmlId(
testCase.getFullName() ) );
@@ -551,12 +545,11 @@ public final class SurefireReportGenerator
private void constructFailureDetails( Sink sink, LocalizedProperties
bundle, List<ReportTestCase> failures )
{
sink.section1();
+ sinkAnchor( sink, "Failure_Details" );
sink.sectionTitle1();
sink.text( bundle.getReportLabelFailureDetails() );
sink.sectionTitle1_();
- sinkAnchor( sink, "Failure_Details" );
-
constructHotLinks( sink, bundle );
sinkLineBreak( sink );
