Author: aheritier Date: Fri Jul 21 14:57:53 2006 New Revision: 424471 URL: http://svn.apache.org/viewvc?rev=424471&view=rev Log: Always place constants on the left side of equals()
Modified: maven/maven-1/core/trunk/src/java/org/apache/maven/werkz/Goal.java Modified: maven/maven-1/core/trunk/src/java/org/apache/maven/werkz/Goal.java URL: http://svn.apache.org/viewvc/maven/maven-1/core/trunk/src/java/org/apache/maven/werkz/Goal.java?rev=424471&r1=424470&r2=424471&view=diff ============================================================================== --- maven/maven-1/core/trunk/src/java/org/apache/maven/werkz/Goal.java (original) +++ maven/maven-1/core/trunk/src/java/org/apache/maven/werkz/Goal.java Fri Jul 21 14:57:53 2006 @@ -278,7 +278,7 @@ */ public void addPostGoalCallback( PostGoalCallback callback ) { - if ( this.postGoalCallbacks.equals( Collections.EMPTY_LIST ) ) + if ( Collections.EMPTY_LIST.equals( this.postGoalCallbacks ) ) { this.postGoalCallbacks = new ArrayList( 3 ); } @@ -414,7 +414,7 @@ public void addPrecursor( Goal precursor ) throws CyclicGoalChainException { - if ( this.precursors.equals( Collections.EMPTY_LIST ) ) + if ( Collections.EMPTY_LIST.equals( this.precursors ) ) { this.precursors = new ArrayList(); } @@ -458,7 +458,7 @@ */ private void addInternalPostcursor( Goal postcursor ) { - if ( this.postcursors.equals( Collections.EMPTY_LIST ) ) + if ( Collections.EMPTY_LIST.equals( this.postcursors ) ) { this.postcursors = new ArrayList(); }