Author: brett
Date: Tue Jul 11 00:40:48 2006
New Revision: 420751

URL: http://svn.apache.org/viewvc?rev=420751&view=rev
Log:
[MNG-2425] add parameters without an expression back to the xdoc
Submitted by: Edwin Punzalan

Modified:
    
maven/components/trunk/maven-plugin-tools/maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java

Modified: 
maven/components/trunk/maven-plugin-tools/maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java
URL: 
http://svn.apache.org/viewvc/maven/components/trunk/maven-plugin-tools/maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java?rev=420751&r1=420750&r2=420751&view=diff
==============================================================================
--- 
maven/components/trunk/maven-plugin-tools/maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java
 (original)
+++ 
maven/components/trunk/maven-plugin-tools/maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java
 Tue Jul 11 00:40:48 2006
@@ -228,18 +228,11 @@
         //remove components and read-only parameters
         List list = filterParameters( parameterList );
 
-        if ( list != null )
+        if ( list != null && list.size() > 0 )
         {
-            if ( list.size() > 0 )
-            {
-                writeParameterSummary( list, w );
+            writeParameterSummary( list, w );
 
-                writeParameterDetails( list, w );
-            }
-            else
-            {
-                w.startElement( "" );
-            }
+            writeParameterDetails( list, w );
         }
     }
 
@@ -255,7 +248,7 @@
             {
                 String expression = parameter.getExpression();
 
-                if ( expression != null && !expression.startsWith( 
"${component." ) )
+                if ( expression == null || !expression.startsWith( 
"${component." ) )
                 {
                     filtered.add( parameter );
                 }


Reply via email to