Author: mperham
Date: Thu Jul  6 08:02:55 2006
New Revision: 419570

URL: http://svn.apache.org/viewvc?rev=419570&view=rev
Log:
Add PMD version to report.  Emit "everything's ok" message in report if no 
errors were found, rather than a blank report.

Modified:
    
maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java

Modified: 
maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java
URL: 
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java?rev=419570&r1=419569&r2=419570&view=diff
==============================================================================
--- 
maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java
 (original)
+++ 
maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java
 Thu Jul  6 08:02:55 2006
@@ -26,6 +26,7 @@
 
 import net.sourceforge.pmd.IRuleViolation;
 import net.sourceforge.pmd.ReportListener;
+import net.sourceforge.pmd.PMD;
 import net.sourceforge.pmd.stat.Metric;
 
 import org.codehaus.doxia.sink.Sink;
@@ -54,6 +55,9 @@
 
     private List violations = new ArrayList();
 
+    // The number of erroneous files
+    private int fileCount = 0;
+
     //private List metrics = new ArrayList();
 
     public PmdReportListener( Sink sink, String sourceDirectory, 
ResourceBundle bundle )
@@ -96,6 +100,7 @@
     // wrt their source line number.  We re-sort them before writing them to 
the report.
     private void processViolations()
     {
+        fileCount++;
         Collections.sort( violations, new Comparator()
         {
             public int compare( Object o1, Object o2 )
@@ -172,6 +177,7 @@
         sink.link( "http://pmd.sourceforge.net/"; );
         sink.text( "PMD" );
         sink.link_();
+        sink.text( " " + PMD.VERSION + "." );
         sink.paragraph_();
 
         // TODO overall summary
@@ -262,6 +268,11 @@
 
     public void endDocument()
     {
+        if ( fileCount == 0 )
+        {
+            sink.text( "PMD found no problems in your source code." );
+        }
+
         sink.section1_();
 
         // The Metrics report useless with the current PMD metrics impl.


Reply via email to