Author: brett
Date: Wed Jun 7 00:44:47 2006
New Revision: 412316
URL: http://svn.apache.org/viewvc?rev=412316&view=rev
Log:
revise tasklist
Modified:
maven/repository-manager/trunk/maven-repository-artifact-applet/src/main/java/org/apache/maven/repository/applet/ChecksumApplet.java
maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/AbstractDiscoverer.java
maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/ArtifactDiscoverer.java
maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/DefaultMetadataDiscoverer.java
maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java
maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/ProxyManager.java
maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/ProxyConfiguration.java
maven/repository-manager/trunk/maven-repository-reports-standard/src/main/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayer.java
maven/repository-manager/trunk/maven-repository-reports-standard/src/test/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayerTest.java
maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/PackageSearchAction.java
maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/RepositoryBrowseAction.java
maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/execution/DiscovererExecution.java
Modified:
maven/repository-manager/trunk/maven-repository-artifact-applet/src/main/java/org/apache/maven/repository/applet/ChecksumApplet.java
URL:
http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-artifact-applet/src/main/java/org/apache/maven/repository/applet/ChecksumApplet.java?rev=412316&r1=412315&r2=412316&view=diff
==============================================================================
---
maven/repository-manager/trunk/maven-repository-artifact-applet/src/main/java/org/apache/maven/repository/applet/ChecksumApplet.java
(original)
+++
maven/repository-manager/trunk/maven-repository-artifact-applet/src/main/java/org/apache/maven/repository/applet/ChecksumApplet.java
Wed Jun 7 00:44:47 2006
@@ -29,7 +29,7 @@
import java.security.PrivilegedAction;
/**
- * TODO: Description.
+ * Applet that takes a file on the local filesystem and checksums it for
sending to the server.
*
* @author <a href="mailto:[EMAIL PROTECTED]">Brett Porter</a>
*/
Modified:
maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/AbstractDiscoverer.java
URL:
http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/AbstractDiscoverer.java?rev=412316&r1=412315&r2=412316&view=diff
==============================================================================
---
maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/AbstractDiscoverer.java
(original)
+++
maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/AbstractDiscoverer.java
Wed Jun 7 00:44:47 2006
@@ -28,7 +28,7 @@
import java.util.List;
/**
- * TODO [!]: Description.
+ * Base class for the artifact and metadata discoverers.
*
* @author <a href="mailto:[EMAIL PROTECTED]">Brett Porter</a>
*/
Modified:
maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/ArtifactDiscoverer.java
URL:
http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/ArtifactDiscoverer.java?rev=412316&r1=412315&r2=412316&view=diff
==============================================================================
---
maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/ArtifactDiscoverer.java
(original)
+++
maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/ArtifactDiscoverer.java
Wed Jun 7 00:44:47 2006
@@ -39,7 +39,6 @@
* @param blacklistedPatterns pattern that lists any files to prevent from
being included when scanning
* @param includeSnapshots whether to discover snapshots
* @return the list of artifacts discovered
- * @todo replace repositoryBase with wagon repository
* @todo do we want blacklisted patterns in another form? Part of the
object construction?
* @todo should includeSnapshots be configuration on the component?
* @todo instead of a returned list, should a listener be passed in?
@@ -53,7 +52,6 @@
* @param blacklistedPatterns pattern that lists any files to prevent from
being included when scanning
* @param includeSnapshots whether to discover snapshots
* @return the list of artifacts discovered
- * @todo replace repositoryBase with wagon repository
* @todo do we want blacklisted patterns in another form? Part of the
object construction?
* @todo should includeSnapshots be configuration on the component?
* @todo instead of a returned list, should a listener be passed in?
Modified:
maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/DefaultMetadataDiscoverer.java
URL:
http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/DefaultMetadataDiscoverer.java?rev=412316&r1=412315&r2=412316&view=diff
==============================================================================
---
maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/DefaultMetadataDiscoverer.java
(original)
+++
maven/repository-manager/trunk/maven-repository-discovery/src/main/java/org/apache/maven/repository/discovery/DefaultMetadataDiscoverer.java
Wed Jun 7 00:44:47 2006
@@ -179,19 +179,19 @@
}
catch ( FileNotFoundException fe )
{
- // TODO: log ignored metadata
+ // TODO: log ignored metadata!
}
catch ( XmlPullParserException xe )
{
- // TODO: log ignored metadata
+ // TODO: log ignored metadata!
}
catch ( MalformedURLException e )
{
- // TODO: log ignored metadata
+ // TODO: log ignored metadata!
}
catch ( IOException ie )
{
- // TODO: log ignored metadata
+ // TODO: log ignored metadata!
}
return metadata;
Modified:
maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java
URL:
http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java?rev=412316&r1=412315&r2=412316&view=diff
==============================================================================
---
maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java
(original)
+++
maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java
Wed Jun 7 00:44:47 2006
@@ -52,7 +52,7 @@
* @author Edwin Punzalan
* @plexus.component role="org.apache.maven.repository.proxy.ProxyManager"
* @todo too much of wagon manager is reproduced here because checksums need
to be downloaded separately - is that necessary?
- * @todo this isn't reusing the parts of wagon manager than handle snapshots
+ * @todo this isn't reusing the parts of wagon manager than handle snapshots
[!]
*/
public class DefaultProxyManager
extends AbstractLogEnabled
@@ -297,13 +297,13 @@
private ArtifactRepositoryPolicy getReleasesPolicy()
{
- //todo get policy configuration from ProxyConfiguration
+ //todo get policy configuration from ProxyConfiguration [!]
return new ArtifactRepositoryPolicy();
}
private ArtifactRepositoryPolicy getSnapshotsPolicy()
{
- //todo get policy configuration from ProxyConfiguration
+ //todo get policy configuration from ProxyConfiguration [!]
return new ArtifactRepositoryPolicy();
}
@@ -392,7 +392,7 @@
{
wagon = wagonManager.getWagon( repository.getProtocol() );
- //@todo configure wagonManager
+ //@todo configure wagonManager [!]
if ( useChecksum )
{
Modified:
maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/ProxyManager.java
URL:
http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/ProxyManager.java?rev=412316&r1=412315&r2=412316&view=diff
==============================================================================
---
maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/ProxyManager.java
(original)
+++
maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/ProxyManager.java
Wed Jun 7 00:44:47 2006
@@ -25,7 +25,7 @@
* Class used to bridge the servlet to the repository proxy implementation.
*
* @author Edwin Punzalan
- * @todo the names get() and getRemoteFile() are confusing
+ * @todo the names get() and getRemoteFile() are confusing [!]
*/
public interface ProxyManager
{
Modified:
maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/ProxyConfiguration.java
URL:
http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/ProxyConfiguration.java?rev=412316&r1=412315&r2=412316&view=diff
==============================================================================
---
maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/ProxyConfiguration.java
(original)
+++
maven/repository-manager/trunk/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/ProxyConfiguration.java
Wed Jun 7 00:44:47 2006
@@ -29,7 +29,7 @@
*
* @author Edwin Punzalan
* @plexus.component
role="org.apache.maven.repository.proxy.configuration.ProxyConfiguration"
- * @todo investigate how these should be set - probably plexus configuration
+ * @todo investigate how these should be set - probably plexus configuration
[!]
*/
public class ProxyConfiguration
{
Modified:
maven/repository-manager/trunk/maven-repository-reports-standard/src/main/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayer.java
URL:
http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-reports-standard/src/main/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayer.java?rev=412316&r1=412315&r2=412316&view=diff
==============================================================================
---
maven/repository-manager/trunk/maven-repository-reports-standard/src/main/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayer.java
(original)
+++
maven/repository-manager/trunk/maven-repository-reports-standard/src/main/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayer.java
Wed Jun 7 00:44:47 2006
@@ -30,8 +30,7 @@
{
private Cache cache;
- private static final double CACHE_HIT_RATIO = 0.5;
-
+ public static final double CACHE_HIT_RATIO = 0.5;
public CachedRepositoryQueryLayer( ArtifactRepository repository )
{
Modified:
maven/repository-manager/trunk/maven-repository-reports-standard/src/test/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayerTest.java
URL:
http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-reports-standard/src/test/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayerTest.java?rev=412316&r1=412315&r2=412316&view=diff
==============================================================================
---
maven/repository-manager/trunk/maven-repository-reports-standard/src/test/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayerTest.java
(original)
+++
maven/repository-manager/trunk/maven-repository-reports-standard/src/test/java/org/apache/maven/repository/reporting/CachedRepositoryQueryLayerTest.java
Wed Jun 7 00:44:47 2006
@@ -22,8 +22,6 @@
public class CachedRepositoryQueryLayerTest
extends AbstractRepositoryQueryLayerTestCase
{
- // TODO: share
- private static final double CACHE_HIT_RATIO = 0.5;
protected void setUp()
throws Exception
@@ -38,7 +36,7 @@
testContainsArtifactTrue();
assertEquals( 0, queryLayer.getCacheHitRate(), 0 );
testContainsArtifactTrue();
- assertEquals( CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 );
+ assertEquals( CachedRepositoryQueryLayer.CACHE_HIT_RATIO,
queryLayer.getCacheHitRate(), 0 );
}
public void testUseMetadataCache()
@@ -47,7 +45,7 @@
testArtifactVersionsTrue();
assertEquals( 0, queryLayer.getCacheHitRate(), 0 );
testArtifactVersionsTrue();
- assertEquals( CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 );
+ assertEquals( CachedRepositoryQueryLayer.CACHE_HIT_RATIO,
queryLayer.getCacheHitRate(), 0 );
}
public void testUseFileCacheOnSnapshot()
@@ -55,6 +53,6 @@
testContainsSnapshotArtifactTrue();
assertEquals( 0, queryLayer.getCacheHitRate(), 0 );
testContainsSnapshotArtifactTrue();
- assertEquals( CACHE_HIT_RATIO, queryLayer.getCacheHitRate(), 0 );
+ assertEquals( CachedRepositoryQueryLayer.CACHE_HIT_RATIO,
queryLayer.getCacheHitRate(), 0 );
}
}
Modified:
maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/PackageSearchAction.java
URL:
http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/PackageSearchAction.java?rev=412316&r1=412315&r2=412316&view=diff
==============================================================================
---
maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/PackageSearchAction.java
(original)
+++
maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/PackageSearchAction.java
Wed Jun 7 00:44:47 2006
@@ -33,7 +33,7 @@
import java.util.List;
/**
- * TODO: Description.
+ * Search by package name.
*
* @author <a href="mailto:[EMAIL PROTECTED]">Brett Porter</a>
* @plexus.component role="com.opensymphony.xwork.Action"
role-hint="org.apache.maven.repository.manager.web.action.PackageSearchAction"
@@ -82,7 +82,7 @@
return ERROR;
}
- // TODO: better config
+ // TODO: better config [!]
String indexPath = configuration.getIndexDirectory();
// TODO: reduce the amount of lookup?
Modified:
maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/RepositoryBrowseAction.java
URL:
http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/RepositoryBrowseAction.java?rev=412316&r1=412315&r2=412316&view=diff
==============================================================================
---
maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/RepositoryBrowseAction.java
(original)
+++
maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/RepositoryBrowseAction.java
Wed Jun 7 00:44:47 2006
@@ -31,7 +31,7 @@
import java.util.TreeMap;
/**
- * TODO: Description.
+ * Browse the repository.
*
* @plexus.component role="com.opensymphony.xwork.Action"
role-hint="org.apache.maven.repository.manager.web.action.RepositoryBrowseAction"
*/
Modified:
maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/execution/DiscovererExecution.java
URL:
http://svn.apache.org/viewvc/maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/execution/DiscovererExecution.java?rev=412316&r1=412315&r2=412316&view=diff
==============================================================================
---
maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/execution/DiscovererExecution.java
(original)
+++
maven/repository-manager/trunk/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/execution/DiscovererExecution.java
Wed Jun 7 00:44:47 2006
@@ -156,7 +156,7 @@
*
* @throws MalformedURLException
* @throws RepositoryIndexException
- * @todo why is this any different from legacy?
+ * @todo why is this any different from legacy? [!]
*/
protected void executeDiscovererInDefaultRepo()
throws MalformedURLException, RepositoryIndexException
