svn commit: r389781 - in /maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release: PrepareReleaseMojo.java helpers/ScmHelper.java

[evenisse]

Author: evenisse
Date: Wed Mar 29 04:28:18 2006
New Revision: 389781

URL: http://svn.apache.org/viewcvs?rev=389781&view=rev
Log:
Used a Set instead of List for pomFiles list as suggested by Kjetil Ødegaard in 
MRELEASE-86

Modified:
    
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
    
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/helpers/ScmHelper.java

Modified: 
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
URL: 
http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java?rev=389781&r1=389780&r2=389781&view=diff
==============================================================================
--- 
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
 (original)
+++ 
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
 Wed Mar 29 04:28:18 2006
@@ -56,6 +56,7 @@
 import java.io.StringWriter;
 import java.io.Writer;
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
@@ -181,7 +182,7 @@
 
     private ProjectScmRewriter scmRewriter;
 
-    private List pomFiles;
+    private Set pomFiles;
 
     public void execute()
         throws MojoExecutionException, MojoFailureException
@@ -1382,7 +1383,7 @@
         }
     }
 
-    private void checkIn( List pomFiles, String message )
+    private void checkIn( Collection pomFiles, String message )
         throws MojoExecutionException
     {
         ScmHelper scm = getScm( basedir.getAbsolutePath() );
@@ -1601,7 +1602,7 @@
     {
         if ( pomFiles == null )
         {
-            pomFiles = new ArrayList();
+            pomFiles = new HashSet();
         }
 
         if ( !pomFiles.contains( pomFile ) )

Modified: 
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/helpers/ScmHelper.java
URL: 
http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/helpers/ScmHelper.java?rev=389781&r1=389780&r2=389781&view=diff
==============================================================================
--- 
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/helpers/ScmHelper.java
 (original)
+++ 
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/helpers/ScmHelper.java
 Wed Mar 29 04:28:18 2006
@@ -39,6 +39,7 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.util.Collection;
 import java.util.List;
 import java.util.ArrayList;
 import java.util.Iterator;
@@ -261,7 +262,7 @@
         checkResult( result );
     }
 
-    public void checkin( List pomFiles, String message )
+    public void checkin( Collection pomFiles, String message )
         throws ScmException
     {
         File[] files = (File[]) pomFiles.toArray( new File[pomFiles.size()] );