This is an automated email from the ASF dual-hosted git repository.
rgupta pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/logging-log4j-kotlin.git
The following commit(s) were added to refs/heads/main by this push:
new 66286e2 Document why spotbugs is disabled for the benchmark module
(#149)
66286e2 is described below
commit 66286e21ec3076746e9809356d9b368a11b757e9
Author: Raman Gupta <[email protected]>
AuthorDate: Tue Mar 31 11:08:31 2026 -0400
Document why spotbugs is disabled for the benchmark module (#149)
* Remove spotbugs skip setting
* Revert "Remove spotbugs skip setting"
This reverts commit fe2d0492dba61750d9141f969f31f6e6824d2179.
* Document why spotbugs is disabled
---
log4j-api-kotlin-benchmark/pom.xml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/log4j-api-kotlin-benchmark/pom.xml
b/log4j-api-kotlin-benchmark/pom.xml
index 698be16..3258df1 100644
--- a/log4j-api-kotlin-benchmark/pom.xml
+++ b/log4j-api-kotlin-benchmark/pom.xml
@@ -35,6 +35,7 @@
<maven.test.skip>true</maven.test.skip>
<maven.deploy.skip>true</maven.deploy.skip>
<maven.install.skip>true</maven.install.skip>
+ <!-- Spotbugs raises false positives because of the compile, generate
sources, compile build chain -->
<spotbugs.skip>true</spotbugs.skip>
<uberjar.name>benchmarks</uberjar.name>
</properties>
@@ -87,7 +88,10 @@
1. Compile JMH-annotated Kotlin sources
2. Using compiled (and JMH-annotated!) classes, generate JMH Java
sources
3. Add JMH Java sources
- 4. Compile JMH Java sources -->
+ 4. Compile JMH Java sources
+
+ Ideally, at some point we can migrate to kotlinx-benchmark, but at
the moment
+ that project only supplies a Gradle plugin. -->
<!-- 1. Compile Kotlin sources -->
<plugin>
