edwardcapriolo commented on PR #506: URL: https://github.com/apache/incubator-livy/pull/506#issuecomment-3764158719
@lmccay >> It's not getting merged while failing test runs on currently supported Java versions and we aren't dropping support for a java version for a clean up pull request failing tests. Of course, I wouldn't ask you to merge something that is breaking. Have you looked at the PR? All i did was change a method that returns a null to a method that returns Option. Did I actually produce bad code or is this simply flaky builds? Jjava8 has optional support so i dont see why it would break? I observe these test fail on MASTER ```shell edward@fedora:~/incubator-livy$ git log | head -10 commit 284467b98b8f086cb3cf9a6813873141bced5dc2 Author: Edward Capriolo <[email protected]> Date: Fri Jan 16 10:24:14 2026 -0500 LIVY-1029 modernize versions (#505) [INFO] --- surefire:2.22.1:test (default-test) @ livy-rsc --- [WARNING] Parameter 'systemProperties' is deprecated: Use systemPropertyVariables instead. [INFO] [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.livy.rsc.TestJobHandle [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.082 s - in org.apache.livy.rsc.TestJobHandle [INFO] Running org.apache.livy.rsc.TestSparkClient [ERROR] Tests run: 19, Failures: 0, Errors: 18, Skipped: 0, Time elapsed: 28.672 s <<< FAILURE! - in org.apache.livy.rsc.TestSparkClient [ERROR] testSyncRpc(org.apache.livy.rsc.TestSparkClient) Time elapsed: 5.65 s <<< ERROR! java.util.concurrent.ExecutionException: java.io.IOException: RSCClient instance stopped. at org.apache.livy.rsc.TestSparkClient.runTest(TestSparkClient.java:593) at org.apache.livy.rsc.TestSparkClient.runTest(TestSparkClient.java:580) at org.apache.livy.rsc.TestSparkClient.testSyncRpc(TestSparkClient.java:202) Caused by: java.io.IOException: RSCClient instance stopped. ``` It isnt a reason to block my commit because the tests dont run at all :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
