ksumit commented on code in PR #394:
URL: https://github.com/apache/incubator-livy/pull/394#discussion_r1149793135
##########
README.md:
##########
@@ -88,3 +88,13 @@ between different Spark versions.
The Livy package itself does not contain a Spark distribution. It will work
with any supported
version of Spark without needing to rebuild.
+
+### Build Profiles
+
+| Flag | Purpose
|
+|-------------|--------------------------------------------------------------------|
+| -Phadoop2 | Choose Hadoop2 based build dependencies (default
configuration) |
+| -Pspark2 | Choose Spark 2.x based build dependencies (default
configuration) |
+| -Pscala-2.11 | Choose Scala 2.11 based build dependencies (default
configuration) |
+| -Pscala-2.12 | Choose scala 2.12 based build dependencies
|
+| -Pspark3 | Choose Spark 3.x based build dependencies |
Review Comment:
It is hardcoded intentionally, getting different versions of hadoop, hive
and spark to play with a version of livy and making it work across their
dependency versions is a hard problem. you would notice that the functionality
to pass and override
[hadoop](https://github.com/apache/incubator-livy/blob/master/pom.xml#L82),
[scala](https://github.com/apache/incubator-livy/blob/master/pom.xml#LL109-L111C57),
[spark](https://github.com/apache/incubator-livy/blob/master/pom.xml#LL86-L86C63)
and other versions is already available but we still need these profiles to
resolve version incompatibilities in dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
