dacort commented on code in PR #393: URL: https://github.com/apache/incubator-livy/pull/393#discussion_r1143898274
########## .github/workflows/integration-tests.yaml: ########## @@ -0,0 +1,54 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +name: Integration Tests +on: + pull_request: + types: [opened, reopened, synchronize] +env: + MAVEN_OPTS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.class=standard -Dmaven.wagon.http.retryHandler.count=3 +jobs: + build: + runs-on: ubuntu-20.04 + # TODO: Possibly point to the ./build-ci-image.yaml with the "uses" key + container: ghcr.io/${{ github.repository_owner }}/livy-ci:latest + strategy: + matrix: + spark_version: ["2.4", "3.0"] + steps: + - + name: Checkout + uses: actions/checkout@v3 + - + name: Cache local Maven repository + uses: actions/cache@v3 + with: + path: | + /root/.m2/repository + !/root/.m2/repository/org/apache/livy + key: ${{ runner.os }}-maven-${{ hashFiles('pom.xml', '*/pom.xml', 'thriftserver/*/pom.xml', 'core/*/pom.xml', 'repl/*/pom.xml', 'scala-api/*/pom.xml') }} Review Comment: It does, but due to the use of the custom `container` there are directories created during the build process that subsequent GitHub actions don't have the ability to access, receiving a "permission denied" error while attempting to process. There's some more info about it here: https://github.com/actions/runner/issues/449 There's a couple options: - Change the userid that the container is running as to specifically be `1001`. - Be more specific with the `pom.xml` paths Option 2 seemed a little safer. ########## .github/workflows/unit-tests.yaml: ########## @@ -0,0 +1,52 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +name: Unit Tests +on: [push] +env: + MAVEN_OPTS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.class=standard -Dmaven.wagon.http.retryHandler.count=3 Review Comment: Yep. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
