idzikovsky commented on code in PR #249:
URL: https://github.com/apache/incubator-livy/pull/249#discussion_r1137058321
##########
rsc/src/main/java/org/apache/livy/rsc/RSCConf.java:
##########
@@ -151,6 +152,12 @@ public String findLocalAddress() throws IOException {
return address.getCanonicalHostName();
}
+ public boolean isRunningOnKubernetes() {
+ return Optional.ofNullable(get("livy.spark.master"))
+ .filter(s -> s.startsWith("k8s"))
+ .isPresent();
+ }
+
Review Comment:
Yeah, seems like that's what I've faced in
https://github.com/apache/incubator-livy/pull/249#discussion_r493348458
However, it seems like it's not affecting functionality, as this function is
used while setting `RPC_SERVER_ADDRESS` here:
https://github.com/apache/incubator-livy/pull/249/files/b87c0cebb65ce7f34e6b4b6b738095be6254cf69#diff-43114318c4b009c2404f7eb326a84c184fb1501a3237c49a771df851d0f6f328R172-R178
And the value of `RPC_SERVER_ADDRESS` is not used anyway since Livy 0.7
because of things I've explained in #388.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
