ksumit commented on code in PR #367:
URL: https://github.com/apache/incubator-livy/pull/367#discussion_r1043910821


##########
.dockerignore:
##########
@@ -0,0 +1,3 @@
+# Build output

Review Comment:
   I was wondering if we move Dockerfile to a separate folder, we won't have to 
keep this `.dockerignore` file at all. This size will grow over time, so that's 
a suggestion. I agree that 8MB may not be significant.
   
   [Here](https://github.com/apache/spark/blob/master/dev/infra/Dockerfile) is 
another example from spark project to consider



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to