dacort commented on code in PR #367: URL: https://github.com/apache/incubator-livy/pull/367#discussion_r1042772262
########## Dockerfile: ########## @@ -0,0 +1,34 @@ +FROM ubuntu:xenial + +# Install necessary dependencies for build/test +RUN apt update && \ + apt install -y \ + apt-transport-https \ + libkrb5-dev \ + maven \ + openjdk-8-jdk \ + python-dev \ + python-pip \ + python3-pip \ + software-properties-common + +# R 3.x install - ensure to add the signing key per https://cran.r-project.org/bin/linux/ubuntu/olderreleasesREADME.html +RUN add-apt-repository 'deb https://cloud.r-project.org/bin/linux/ubuntu xenial-cran35/' && \ + apt-key adv --keyserver keyserver.ubuntu.com --recv-keys E298A3A825C0D65DFD57CBB651716619E084DAB9 && \ + apt-get update && \ + apt-get -y install r-base + +# Add build dependencies for python2 +# - First we upgrade pip because that makes a lot of things better +# - Then we remove the provided version of setuptools and install a different version +# - Then we install additional dependencies +RUN python -m pip install -U "pip < 21.0" +RUN apt-get remove -y python-setuptools +RUN python -m pip install "setuptools < 36" +RUN python -m pip install "requests >= 2.10.0" "responses >= 0.5.1" "futures>=3.0.5" "future>=0.15.2" pytest pytest-runner flaky flake8 requests-kerberos install codecov cloudpickle + Review Comment: I can double-check with setuptools specifically, but I know with the pip upgrade, it needs to run as two separate commands for the pip upgrade ot take effect. I _think_ `setuptools` is the same, but I should actually be able to at least squash lines#26-27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
