This is an automated email from the ASF dual-hosted git repository.
jlfsdtc pushed a commit to branch kylin5
in repository https://gitbox.apache.org/repos/asf/kylin.git
The following commit(s) were added to refs/heads/kylin5 by this push:
new a5e084ffa1 KYLIN-6084 Incorrect error message in internal table
refresh API
a5e084ffa1 is described below
commit a5e084ffa131ad1cec5f52b24e3a0a008db624a2
Author: jlf <[email protected]>
AuthorDate: Mon Oct 20 10:53:53 2025 +0800
KYLIN-6084 Incorrect error message in internal table refresh API
---
.../kylin/rest/service/InternalTableLoadingService.java | 2 +-
.../kylin/engine/spark/job/InternalTableLoadingJob.java | 6 +++---
.../engine/spark/job/InternalTableUpdateMetadataStep.java | 12 ++++++------
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git
a/src/datasource-service/src/main/java/org/apache/kylin/rest/service/InternalTableLoadingService.java
b/src/datasource-service/src/main/java/org/apache/kylin/rest/service/InternalTableLoadingService.java
index 884f26bb70..430c3c3223 100644
---
a/src/datasource-service/src/main/java/org/apache/kylin/rest/service/InternalTableLoadingService.java
+++
b/src/datasource-service/src/main/java/org/apache/kylin/rest/service/InternalTableLoadingService.java
@@ -146,7 +146,7 @@ public class InternalTableLoadingService extends
BasicService {
// check refresh out of data range(exclude specify partitions)
if (isRefresh && finalPartitions.length == 0
&& !DataRangeUtils.timeInRange(range,
internalTable.getPartitionRange(), timeFmt)) {
- String errorMsg = String.format(Locale.ROOT,
MsgPicker.getMsg().getInternalTableUnpartitioned());
+ String errorMsg = String.format(Locale.ROOT,
MsgPicker.getMsg().getTimeOutOfRange());
throw new KylinException(INTERNAL_TABLE_ERROR, errorMsg);
}
});
diff --git
a/src/spark-project/engine-spark/src/main/java/org/apache/kylin/engine/spark/job/InternalTableLoadingJob.java
b/src/spark-project/engine-spark/src/main/java/org/apache/kylin/engine/spark/job/InternalTableLoadingJob.java
index c73a9d7f44..3a5ad9973d 100644
---
a/src/spark-project/engine-spark/src/main/java/org/apache/kylin/engine/spark/job/InternalTableLoadingJob.java
+++
b/src/spark-project/engine-spark/src/main/java/org/apache/kylin/engine/spark/job/InternalTableLoadingJob.java
@@ -107,7 +107,7 @@ public class InternalTableLoadingJob extends
DefaultExecutableOnTable {
InternalTableManager internalTableManager =
InternalTableManager.getInstance(getConfig(), getProject());
InternalTableDesc internalTable =
internalTableManager.getInternalTableDesc(getTableIdentity());
if (null == internalTable) {
- logger.debug("internalTable is null, maybe internalTable is
deleted ?");
+ logger.debug("InternalTable is null, maybe internalTable is
deleted ?");
return true;
}
String tableName = getParam(NBatchConstants.P_TABLE_NAME);
@@ -118,7 +118,7 @@ public class InternalTableLoadingJob extends
DefaultExecutableOnTable {
boolean isIncremental =
"true".equals(getParam(NBatchConstants.P_INCREMENTAL_BUILD));
InternalTablePartition tablePartition =
internalTable.getTablePartition();
// merge latest partition_range
- logger.info("starting merging delta partitions for internal table
{}", tableName);
+ logger.info("Starting merging delta partitions for internal table
{}", tableName);
if (null != tablePartition &&
StringUtils.isNotEmpty(tablePartition.getDatePartitionFormat())) {
List<String[]> partitionRange =
DataRangeUtils.mergeTimeRange(tablePartition.getPartitionValues(),
tablePartition.getDatePartitionFormat());
@@ -128,7 +128,7 @@ public class InternalTableLoadingJob extends
DefaultExecutableOnTable {
InternalTableUpdateMetadataStep metadataStep = new
InternalTableUpdateMetadataStep();
metadataStep.releaseJobRange(internalTable, isIncremental,
startDate, endDate, refreshPartitions);
internalTableManager.saveOrUpdateInternalTable(internalTable);
- logger.info("release job_range for internal table {} ", tableName);
+ logger.info("Release job_range for internal table {} ", tableName);
return true;
}, getProject());
}
diff --git
a/src/spark-project/engine-spark/src/main/java/org/apache/kylin/engine/spark/job/InternalTableUpdateMetadataStep.java
b/src/spark-project/engine-spark/src/main/java/org/apache/kylin/engine/spark/job/InternalTableUpdateMetadataStep.java
index abf20ba3a7..da5d1cbd69 100644
---
a/src/spark-project/engine-spark/src/main/java/org/apache/kylin/engine/spark/job/InternalTableUpdateMetadataStep.java
+++
b/src/spark-project/engine-spark/src/main/java/org/apache/kylin/engine/spark/job/InternalTableUpdateMetadataStep.java
@@ -108,7 +108,7 @@ public class InternalTableUpdateMetadataStep extends
AbstractExecutable {
tablePartition.setPartitionDetails(info.getPartitionDetails());
}
internalTable.setRowCount(info.getFinalCount());
- logger.info("starting merging delta partitions");
+ logger.info("Starting merging delta partitions");
if (null != tablePartition &&
StringUtils.isNotEmpty(tablePartition.getDatePartitionFormat())) {
List<String[]> partitionRange =
DataRangeUtils.mergeTimeRange(tablePartition.getPartitionValues(),
tablePartition.getDatePartitionFormat());
@@ -116,7 +116,7 @@ public class InternalTableUpdateMetadataStep extends
AbstractExecutable {
}
releaseJobRange(internalTable, isIncremental, startDate, endDate,
refreshPartitions);
internalTableManager.saveOrUpdateInternalTable(internalTable);
- logger.info("update metadata for internal table {} cost: {} ms.",
+ logger.info("Update metadata for internal table {} cost: {} ms.",
internalTable.getTableDesc().getTableAlias(),
(System.currentTimeMillis() - startTime));
return true;
}, project);
@@ -126,7 +126,7 @@ public class InternalTableUpdateMetadataStep extends
AbstractExecutable {
String endDate, String refreshPartitions) throws Exception {
InternalTablePartition tablePartition =
internalTable.getTablePartition();
// release current job_range
- logger.info("starting releasing job_range");
+ logger.info("Starting releasing job_range");
List<String[]> curRange = Lists.newArrayList();
if (!isIncremental) {
curRange.add(new String[] { "0", "0" });
@@ -147,7 +147,7 @@ public class InternalTableUpdateMetadataStep extends
AbstractExecutable {
jobRange.removeIf(range -> range[0].equals(curJobRange[0]) &&
range[1].equals(curJobRange[1]));
});
internalTable.setJobRange(jobRange);
- logger.info("trying to release job_range for internal table {} , range
{}.",
+ logger.info("Trying to release job_range for internal table {} , range
{}.",
internalTable.getTableDesc().getTableAlias(), jobRange);
}
@@ -166,7 +166,7 @@ public class InternalTableUpdateMetadataStep extends
AbstractExecutable {
if (!partitionDetails.isEmpty()) {
partitionDetails.sort(Comparator.comparing(InternalTablePartitionDetail::getPartitionValue));
}
- logger.info("update internal table meta data : row count:{}, partition
size:{}", count,
+ logger.info("Update internal table meta data : row count:{}, partition
size:{}", count,
partitionDetails.size());
List<String> finalPartitionValues = partitionDetails.stream()
.map(InternalTablePartitionDetail::getPartitionValue).collect(Collectors.toList());
@@ -238,7 +238,7 @@ public class InternalTableUpdateMetadataStep extends
AbstractExecutable {
partitionDetails.add(detail);
}
}
- logger.info("[ UPDATE_INTERNAL_TABLE] extract partitions from delta
table cost {} ms",
+ logger.info("[ UPDATE_INTERNAL_TABLE ] extract partitions from delta
table cost {} ms",
System.currentTimeMillis() - startTime);
return partitionDetails;
}
