This is an automated email from the ASF dual-hosted git repository.
liyang pushed a commit to branch kylin5
in repository https://gitbox.apache.org/repos/asf/kylin.git
The following commit(s) were added to refs/heads/kylin5 by this push:
new e734e6e31b KYLIN-5819,optimize the warning message on the dialog for
editing computed column
e734e6e31b is described below
commit e734e6e31bd035c59c945ecfa99b136d2f6380b4
Author: huangchunyan <qingyanxiaon...@163.com>
AuthorDate: Fri Apr 5 15:25:32 2024 +0800
KYLIN-5819,optimize the warning message on the dialog for editing computed
column
---
kystudio/src/components/common/GlobalDialog/dialog/detail_dialog.vue | 2 +-
kystudio/src/components/studio/StudioModel/AddCCModal/locales.js | 2 +-
.../components/studio/StudioModel/ModelList/ModelSaveConfig/index.vue | 4 ++--
.../studio/StudioModel/ModelList/ModelSaveConfig/locales.js | 3 ++-
4 files changed, 6 insertions(+), 5 deletions(-)
diff --git
a/kystudio/src/components/common/GlobalDialog/dialog/detail_dialog.vue
b/kystudio/src/components/common/GlobalDialog/dialog/detail_dialog.vue
index 1307c2f737..ec1f04335c 100644
--- a/kystudio/src/components/common/GlobalDialog/dialog/detail_dialog.vue
+++ b/kystudio/src/components/common/GlobalDialog/dialog/detail_dialog.vue
@@ -91,7 +91,7 @@
<template v-else>
<el-button v-if="needResolveCancel" :type="isSubSubmit? 'primary': ''"
:text="isSubSubmit" @click="handleCloseAndResove">{{cancelT}}</el-button>
<el-button :type="isSubSubmit? 'primary': ''" :text="isSubSubmit"
v-else :class="[needResolveCancel && 'ksd-ml-12']"
@click="handleClose">{{cancelT}}</el-button>
- <el-button v-if="isSubSubmit" :loading="loading&&!isBulidLoading"
:disabled="loading&&isBulidLoading" class="ksd-ml-12"
@click="handleSubmit(false)">{{submitSubText}}</el-button>
+ <el-button v-if="isSubSubmit" :type="isHideSubmit? 'primary': ''"
:loading="loading&&!isBulidLoading" :disabled="loading&&isBulidLoading"
class="ksd-ml-12" @click="handleSubmit(false)">{{submitSubText}}</el-button>
<el-button type="primary" v-if="!isHideSubmit" class="ksd-ml-12"
:loading="loading&&isBulidLoading" :disabled="loading&&!isBulidLoading"
@click="handleSubmit(true)">{{submitT}}</el-button>
</template>
</div>
diff --git a/kystudio/src/components/studio/StudioModel/AddCCModal/locales.js
b/kystudio/src/components/studio/StudioModel/AddCCModal/locales.js
index e437f7077b..87988ac338 100644
--- a/kystudio/src/components/studio/StudioModel/AddCCModal/locales.js
+++ b/kystudio/src/components/studio/StudioModel/AddCCModal/locales.js
@@ -1,5 +1,5 @@
export default {
en: {
- editCCTip: 'Please be aware that the modified expression would be
effective until all the related indexes have been built.'
+ editCCTip: 'Modify with caution, it may cause query performance
degradation! If the edited computed column is used as a dimension or metric,
the system will delete the relevant index and generate new index. The query
performance will not be restored until the build index job is done.'
}
}
diff --git
a/kystudio/src/components/studio/StudioModel/ModelList/ModelSaveConfig/index.vue
b/kystudio/src/components/studio/StudioModel/ModelList/ModelSaveConfig/index.vue
index 13839e9a1c..d8ded0cc7b 100644
---
a/kystudio/src/components/studio/StudioModel/ModelList/ModelSaveConfig/index.vue
+++
b/kystudio/src/components/studio/StudioModel/ModelList/ModelSaveConfig/index.vue
@@ -785,13 +785,13 @@ export default class ModelPartitionModal extends Vue {
try {
const res = await this.callGlobalDetailDialog({
msg: this.$t('editCCBuildTip'),
- title: this.$t('kylinLang.common.tip'),
+ title: this.$t('editCCBuildTipTitle'),
dialogType: 'warning',
showDetailBtn: false,
isSubSubmit: true,
+ isHideSubmit: true,
wid: '600px',
submitSubText: this.$t('kylinLang.common.save'),
- submitText: this.$t('saveAndLoad'),
needConcelReject: true
})
this.handleClose(true, res.isOnlySave)
diff --git
a/kystudio/src/components/studio/StudioModel/ModelList/ModelSaveConfig/locales.js
b/kystudio/src/components/studio/StudioModel/ModelList/ModelSaveConfig/locales.js
index 441fb30e54..1bd439fbde 100644
---
a/kystudio/src/components/studio/StudioModel/ModelList/ModelSaveConfig/locales.js
+++
b/kystudio/src/components/studio/StudioModel/ModelList/ModelSaveConfig/locales.js
@@ -38,7 +38,8 @@ export default {
incrementalTips: 'It will load data incrementally based on the selected
partition column, which is more resource-efficient.',
fullLoadTips: 'The system will load all data',
changeBuildTypeTips: 'With partition setting changed, all segments and
data would be deleted. The model couldn\'t serve queries. Meanwhile, the
related ongoing jobs for building index would be discarded.',
- editCCBuildTip: 'The modified expression of computed column would be
effective until all the related indexes have been built. Do you want to save
and build index now? ',
+ editCCBuildTipTitle: 'Will delete and generate new indexes, continue to
save model?',
+ editCCBuildTip: 'Query performance will degrade until the new index are
built! Modification of a computed column as a dimension or metric in the
current model will cause the system to delete the relevant index and generate
new index. The query performance will not be restored until the build index job
is done.',
saveAndBuild: 'Save and Build',
purgeSegmentDataTips: 'Model definition has changed. Once saving the
model, all data in the segments will be deleted. As a result, this model CAN\'T
be used to serve queries. We strongly recommend to reload all data (in total
{storageSize}).\r\n Do you want to continue?',
onlyAddLeftJoinTip: 'The model definition relationship has changed and the
current change only affects incremental data. To overwrite the stock data, go
to the Segment page to clear the old data and rebuild.',
