[kylin] 15/24: KYLIN-5694 The CONCAT function supports scenarios with less than two parameters

[xxyu]

This is an automated email from the ASF dual-hosted git repository.

xxyu pushed a commit to branch kylin5
in repository https://gitbox.apache.org/repos/asf/kylin.git

commit 6e29706df4b6f0edd60c6d0b5e26f4162d28665e
Author: Pengfei Zhan <dethr...@gmail.com>
AuthorDate: Tue May 23 10:27:53 2023 +0800

    KYLIN-5694 The CONCAT function supports scenarios with less than two 
parameters
---
 .../main/java/org/apache/kylin/query/udf/stringUdf/ConcatUDF.java | 8 ++++----
 .../src/test/java/org/apache/kylin/query/udf/StringUDFTest.java   | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/src/query/src/main/java/org/apache/kylin/query/udf/stringUdf/ConcatUDF.java 
b/src/query/src/main/java/org/apache/kylin/query/udf/stringUdf/ConcatUDF.java
index 841cc16bfe..faa8142e11 100644
--- 
a/src/query/src/main/java/org/apache/kylin/query/udf/stringUdf/ConcatUDF.java
+++ 
b/src/query/src/main/java/org/apache/kylin/query/udf/stringUdf/ConcatUDF.java
@@ -18,6 +18,9 @@
 
 package org.apache.kylin.query.udf.stringUdf;
 
+import java.util.Arrays;
+import java.util.stream.Collectors;
+
 import org.apache.calcite.adapter.enumerable.CallImplementor;
 import org.apache.calcite.adapter.enumerable.UdfMethodNameImplementor;
 import org.apache.calcite.rel.type.RelDataType;
@@ -32,9 +35,6 @@ import org.apache.calcite.sql.type.SqlOperandCountRanges;
 import org.apache.calcite.sql.type.SqlTypeName;
 import org.apache.calcite.sql.type.SqlTypeTransforms;
 
-import java.util.Arrays;
-import java.util.stream.Collectors;
-
 public class ConcatUDF implements UdfDef {
 
     private static final String FUNC_NAME = "CONCAT";
@@ -50,7 +50,7 @@ public class ConcatUDF implements UdfDef {
             }, SqlTypeTransforms.TO_NULLABLE),
             (callBinding, returnType, operandTypes) -> 
Arrays.fill(operandTypes,
                     callBinding.getTypeFactory().createJavaType(Object.class)),
-            OperandTypes.repeat(SqlOperandCountRanges.from(2), 
OperandTypes.ANY), null,
+            OperandTypes.repeat(SqlOperandCountRanges.from(0), 
OperandTypes.ANY), null,
             SqlFunctionCategory.USER_DEFINED_FUNCTION);
 
     public static final CallImplementor IMPLEMENTOR = new 
UdfMethodNameImplementor(FUNC_NAME.toLowerCase(),
diff --git 
a/src/query/src/test/java/org/apache/kylin/query/udf/StringUDFTest.java 
b/src/query/src/test/java/org/apache/kylin/query/udf/StringUDFTest.java
index 799660a37f..b0f1543be4 100644
--- a/src/query/src/test/java/org/apache/kylin/query/udf/StringUDFTest.java
+++ b/src/query/src/test/java/org/apache/kylin/query/udf/StringUDFTest.java
@@ -57,7 +57,7 @@ public class StringUDFTest {
     }
 
     @Test
-    public void testInitCapbUDF() throws Exception {
+    public void testInitCapbUDF() {
         InitCapbUDF icu = new InitCapbUDF();
         String str1 = icu.INITCAPB("abc DEF 123aVC 124Btd,lAsT");
         assertEquals("Abc Def 123avc 124btd,Last", str1);