This is an automated email from the ASF dual-hosted git repository.

nic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kylin.git

commit abd94c4f27fff8492c3504c4cf156ad04ac81ae9
Author: etherge <ethe...@163.com>
AuthorDate: Fri Feb 14 18:30:49 2020 -0500

    minor, Non-thread-safe fields should not be static
---
 .../org/apache/kylin/common/persistence/RootPersistentEntity.java     | 4 ----
 .../org/apache/kylin/engine/mr/BatchOptimizeJobCheckpointBuilder.java | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git 
a/core-common/src/main/java/org/apache/kylin/common/persistence/RootPersistentEntity.java
 
b/core-common/src/main/java/org/apache/kylin/common/persistence/RootPersistentEntity.java
index a8c6142..98b2cc5 100644
--- 
a/core-common/src/main/java/org/apache/kylin/common/persistence/RootPersistentEntity.java
+++ 
b/core-common/src/main/java/org/apache/kylin/common/persistence/RootPersistentEntity.java
@@ -19,9 +19,6 @@
 package org.apache.kylin.common.persistence;
 
 import java.io.Serializable;
-import java.text.DateFormat;
-import java.text.SimpleDateFormat;
-import java.util.Locale;
 
 import org.apache.commons.lang.time.FastDateFormat;
 import org.apache.kylin.common.KylinVersion;
@@ -46,7 +43,6 @@ abstract public class RootPersistentEntity implements 
AclEntity, Serializable {
 
     static final String DATE_PATTERN = "yyyy-MM-dd HH:mm:ss z";
     static FastDateFormat format = FastDateFormat.getInstance(DATE_PATTERN);
-    static DateFormat df = new SimpleDateFormat(DATE_PATTERN, Locale.ROOT);
 
     public static String formatTime(long millis) {
         return format.format(millis);
diff --git 
a/engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchOptimizeJobCheckpointBuilder.java
 
b/engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchOptimizeJobCheckpointBuilder.java
index a06fd46..9704f66 100644
--- 
a/engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchOptimizeJobCheckpointBuilder.java
+++ 
b/engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchOptimizeJobCheckpointBuilder.java
@@ -36,7 +36,7 @@ import com.google.common.base.Preconditions;
 
 public class BatchOptimizeJobCheckpointBuilder {
 
-    protected static SimpleDateFormat format = new SimpleDateFormat("z 
yyyy-MM-dd HH:mm:ss", Locale.ROOT);
+    protected SimpleDateFormat format = new SimpleDateFormat("z yyyy-MM-dd 
HH:mm:ss", Locale.ROOT);
 
     final protected CubeInstance cube;
     final protected String submitter;

Reply via email to