This is an automated email from the ASF dual-hosted git repository.

nic pushed a commit to branch 2.6.x
in repository https://gitbox.apache.org/repos/asf/kylin.git


The following commit(s) were added to refs/heads/2.6.x by this push:
     new 45db62f  KYLIN-4020 fix_length rowkey encode without sepecified length 
can be saved but cause CreateHTable step failed
45db62f is described below

commit 45db62f9cd617233516e72f7f4ee0ea47cb36fb1
Author: yuzhang <shifengdefan...@163.com>
AuthorDate: Thu May 30 01:34:17 2019 +0800

    KYLIN-4020 fix_length rowkey encode without sepecified length can be saved 
but cause CreateHTable step failed
---
 webapp/app/js/controllers/cubeSchema.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/webapp/app/js/controllers/cubeSchema.js 
b/webapp/app/js/controllers/cubeSchema.js
index 5eed9b9..287f462 100755
--- a/webapp/app/js/controllers/cubeSchema.js
+++ b/webapp/app/js/controllers/cubeSchema.js
@@ -374,6 +374,9 @@ KylinApp.controller('CubeSchemaCtrl', function ($scope, 
QueryService, UserServic
           if(rowkey.encoding.substr(0,3)=='int' && 
(rowkey.encoding.substr(4)<1 || rowkey.encoding.substr(4)>8)){
             errors.push("int encoding column length should between 1 and 8.");
           }
+          if(rowkey.encoding.substr(0, 5) == 'fixed' && 
(!/^[1-9]\d*$/.test(rowkey.encoding.split(':')[1]))) {
+            errors.push("fixed encoding need a valid length.")
+          }
         })
         if(shardRowkeyList.length >1){
           errors.push("At most one 'shard by' column is allowed.");

Reply via email to