This is an automated email from the ASF dual-hosted git repository.

shaofengshi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kylin.git

commit 6f760efb41deab05a3ac4499851ed98e59a74a7b
Author: chao long <wayn...@qq.com>
AuthorDate: Thu Dec 20 10:45:51 2018 +0800

    Minor, delete file before create it
---
 .../apache/kylin/common/metrics/metrics2/JsonFileMetricsReporter.java  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/core-common/src/main/java/org/apache/kylin/common/metrics/metrics2/JsonFileMetricsReporter.java
 
b/core-common/src/main/java/org/apache/kylin/common/metrics/metrics2/JsonFileMetricsReporter.java
index 40cb0a6..c07a997 100644
--- 
a/core-common/src/main/java/org/apache/kylin/common/metrics/metrics2/JsonFileMetricsReporter.java
+++ 
b/core-common/src/main/java/org/apache/kylin/common/metrics/metrics2/JsonFileMetricsReporter.java
@@ -98,9 +98,10 @@ public class JsonFileMetricsReporter implements 
CodahaleReporter {
                         return;
                     }
 
+                    fs.delete(tmpPath, true);
+
                     try (BufferedWriter bw = new BufferedWriter(
                             new OutputStreamWriter(fs.create(tmpPath, true), 
StandardCharsets.UTF_8))) {
-                        fs.delete(tmpPath, true);
                         bw.write(json);
                         fs.setPermission(tmpPath, 
FsPermission.createImmutable((short) 0644));
                     } catch (IOException e) {

Reply via email to