Repository: kylin Updated Branches: refs/heads/master d2982dc17 -> 29d3dc37e
Revert "KYLIN-2720 Should not allow user to access to all tables' metadata of a project" This reverts commit 84ba5615898de99e154d0e13912a82815a0cf02f. Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/29d3dc37 Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/29d3dc37 Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/29d3dc37 Branch: refs/heads/master Commit: 29d3dc37e576b9d927dae6aad3446dcdfd14c565 Parents: d2982dc Author: Hongbin Ma <mahong...@apache.org> Authored: Tue Aug 1 10:21:45 2017 +0800 Committer: Hongbin Ma <mahong...@apache.org> Committed: Tue Aug 1 10:21:45 2017 +0800 ---------------------------------------------------------------------- .../apache/kylin/rest/service/QueryService.java | 56 +------------------- 1 file changed, 2 insertions(+), 54 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/29d3dc37/server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java ---------------------------------------------------------------------- diff --git a/server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java b/server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java index 3c97f88..673b11b 100644 --- a/server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java +++ b/server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java @@ -142,10 +142,6 @@ public class QueryService extends BasicService { private ModelService modelService; @Autowired - @Qualifier("cubeMgmtService") - private CubeService cubeService; - - @Autowired private AclUtil aclUtil; public QueryService() { @@ -512,32 +508,6 @@ public class QueryService extends BasicService { } protected List<TableMeta> getMetadata(CubeManager cubeMgr, String project, boolean cubedOnly) throws SQLException { - //list all tableMetas first - List<TableMeta> tableMetas = listAllMetadata(cubeMgr, project, cubedOnly); - - //get cubes that current user can access to in this project, then get all tables of these cubes. - List<CubeInstance> cubeInstances = cubeService.listAllCubes(null, project, null, true); - Set<TableRef> tableRefs = new HashSet<TableRef>(); - for (CubeInstance cube : cubeInstances) { - tableRefs.addAll(cube.getDescriptor().getModel().getAllTables()); - } - - //filter out tableMetas that current user should not access to - List<TableMeta> filterTableMetas = new ArrayList<TableMeta>(); - for (TableMeta tableMeta : tableMetas) { - String fullTableName = tableMeta.getTABLE_SCHEM() + "." + tableMeta.getTABLE_NAME(); - for (TableRef t : tableRefs) { - if (t.getTableIdentity().equals(fullTableName)) { - filterTableMetas.add(tableMeta); - break; - } - } - } - - return filterTableMetas; - } - - protected List<TableMeta> listAllMetadata(CubeManager cubeMgr, String project, boolean cubedOnly) throws SQLException { Connection conn = null; ResultSet columnMeta = null; @@ -605,33 +575,11 @@ public class QueryService extends BasicService { } public List<TableMetaWithType> getMetadataV2(String project) throws SQLException, IOException { - //list all tableMetas first - List<TableMetaWithType> tableMetas = listAllMetadataV2(getCubeManager(), project, true); - - //get cubes that current user can access to in this project, then get all tables of these cubes. - List<CubeInstance> cubeInstances = cubeService.listAllCubes(null, project, null, true); - Set<TableRef> tableRefs = new HashSet<TableRef>(); - for (CubeInstance cube : cubeInstances) { - tableRefs.addAll(cube.getDescriptor().getModel().getAllTables()); - } - - //filter out tableMetas that current user should not access to - List<TableMetaWithType> filterTableMetas = new ArrayList<TableMetaWithType>(); - for (TableMetaWithType tableMeta : tableMetas) { - String fullTableName = tableMeta.getTABLE_SCHEM() + "." + tableMeta.getTABLE_NAME(); - for (TableRef t : tableRefs) { - if (t.getTableIdentity().equals(fullTableName)) { - filterTableMetas.add(tableMeta); - break; - } - } - } - - return filterTableMetas; + return getMetadataV2(getCubeManager(), project, true); } @SuppressWarnings("checkstyle:methodlength") - protected List<TableMetaWithType> listAllMetadataV2(CubeManager cubeMgr, String project, boolean cubedOnly) + protected List<TableMetaWithType> getMetadataV2(CubeManager cubeMgr, String project, boolean cubedOnly) throws SQLException, IOException { //Message msg = MsgPicker.getMsg();
