minor, cleanup unused logs
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/32b8f2c7 Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/32b8f2c7 Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/32b8f2c7 Branch: refs/heads/master Commit: 32b8f2c7fe7e4179dec9ce1ccafac917dbe2eb27 Parents: 0e0c970 Author: lidongsjtu <lid...@apache.org> Authored: Wed May 3 19:45:10 2017 +0800 Committer: hongbin ma <m...@kyligence.io> Committed: Wed May 3 20:00:29 2017 +0800 ---------------------------------------------------------------------- .../main/java/org/apache/kylin/common/KylinConfig.java | 2 +- .../apache/kylin/job/execution/AbstractExecutable.java | 4 ++-- .../apache/kylin/dimension/DimensionEncodingFactory.java | 2 -- .../metadata/filter/BuiltInFunctionTupleFilter.java | 2 +- .../apache/kylin/metadata/project/ProjectL2Cache.java | 2 +- .../kylin/engine/mr/common/HadoopShellExecutable.java | 3 +-- .../org/apache/kylin/rest/service/DiagnosisService.java | 11 +++-------- .../java/org/apache/kylin/tool/CubeMetaExtractor.java | 2 +- 8 files changed, 10 insertions(+), 18 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/32b8f2c7/core-common/src/main/java/org/apache/kylin/common/KylinConfig.java ---------------------------------------------------------------------- diff --git a/core-common/src/main/java/org/apache/kylin/common/KylinConfig.java b/core-common/src/main/java/org/apache/kylin/common/KylinConfig.java index c00054f..04af9f5 100644 --- a/core-common/src/main/java/org/apache/kylin/common/KylinConfig.java +++ b/core-common/src/main/java/org/apache/kylin/common/KylinConfig.java @@ -232,7 +232,7 @@ public class KylinConfig extends KylinConfigBase { return getKylinPropertiesFile(kylinConfHome); } - logger.warn("KYLIN_CONF property was not set, will seek KYLIN_HOME env variable"); + logger.debug("KYLIN_CONF property was not set, will seek KYLIN_HOME env variable"); String kylinHome = getKylinHome(); if (StringUtils.isEmpty(kylinHome)) http://git-wip-us.apache.org/repos/asf/kylin/blob/32b8f2c7/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java ---------------------------------------------------------------------- diff --git a/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java b/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java index cd9b033..1f1be41 100644 --- a/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java +++ b/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java @@ -255,7 +255,7 @@ public abstract class AbstractExecutable implements Executable, Idempotent { try { List<String> users = getAllNofifyUsers(config); if (users.isEmpty()) { - logger.warn("no need to send email, user list is empty"); + logger.debug("no need to send email, user list is empty"); return; } final Pair<String, String> email = formatNotifications(context, state); @@ -293,7 +293,7 @@ public abstract class AbstractExecutable implements Executable, Idempotent { try { List<String> users = getAllNofifyUsers(config); if (users.isEmpty()) { - logger.warn("no need to send email, user list is empty"); + logger.debug("no need to send email, user list is empty"); return; } doSendMail(config, users, email); http://git-wip-us.apache.org/repos/asf/kylin/blob/32b8f2c7/core-metadata/src/main/java/org/apache/kylin/dimension/DimensionEncodingFactory.java ---------------------------------------------------------------------- diff --git a/core-metadata/src/main/java/org/apache/kylin/dimension/DimensionEncodingFactory.java b/core-metadata/src/main/java/org/apache/kylin/dimension/DimensionEncodingFactory.java index 3eddba7..8f1fcd6 100644 --- a/core-metadata/src/main/java/org/apache/kylin/dimension/DimensionEncodingFactory.java +++ b/core-metadata/src/main/java/org/apache/kylin/dimension/DimensionEncodingFactory.java @@ -18,7 +18,6 @@ package org.apache.kylin.dimension; -import java.util.Arrays; import java.util.Map; import javax.annotation.Nullable; @@ -54,7 +53,6 @@ public abstract class DimensionEncodingFactory { * Create a DimensionEncoding instance, with inputs corresponding to RowKeyColDesc.encodingName and RowKeyColDesc.encodingArgs. */ public static DimensionEncoding create(String encodingName, String[] args, int version) { - logger.debug("Encoding Name : {}, args : {}, version {}", encodingName, Arrays.toString(args), version); if (factoryMap == null) initFactoryMap(); http://git-wip-us.apache.org/repos/asf/kylin/blob/32b8f2c7/core-metadata/src/main/java/org/apache/kylin/metadata/filter/BuiltInFunctionTupleFilter.java ---------------------------------------------------------------------- diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/filter/BuiltInFunctionTupleFilter.java b/core-metadata/src/main/java/org/apache/kylin/metadata/filter/BuiltInFunctionTupleFilter.java index 90123c4..767d868 100755 --- a/core-metadata/src/main/java/org/apache/kylin/metadata/filter/BuiltInFunctionTupleFilter.java +++ b/core-metadata/src/main/java/org/apache/kylin/metadata/filter/BuiltInFunctionTupleFilter.java @@ -130,7 +130,7 @@ public class BuiltInFunctionTupleFilter extends FunctionTupleFilter { else methodParams.add((Serializable) clazz.cast(clazz.getDeclaredMethod("valueOf", String.class).invoke(null, constVal))); } catch (Exception e) { - logger.warn(e.getMessage()); + logger.warn("Reflection failed for methodParams. ", e); isValidFunc = false; } } http://git-wip-us.apache.org/repos/asf/kylin/blob/32b8f2c7/core-metadata/src/main/java/org/apache/kylin/metadata/project/ProjectL2Cache.java ---------------------------------------------------------------------- diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/project/ProjectL2Cache.java b/core-metadata/src/main/java/org/apache/kylin/metadata/project/ProjectL2Cache.java index 14d7843..63188a1 100644 --- a/core-metadata/src/main/java/org/apache/kylin/metadata/project/ProjectL2Cache.java +++ b/core-metadata/src/main/java/org/apache/kylin/metadata/project/ProjectL2Cache.java @@ -168,7 +168,7 @@ class ProjectL2Cache { } private ProjectCache loadCache(String project) { - logger.info("Loading L2 project cache for " + project); + logger.debug("Loading L2 project cache for " + project); ProjectCache projectCache = new ProjectCache(project); ProjectInstance pi = mgr.getProject(project); http://git-wip-us.apache.org/repos/asf/kylin/blob/32b8f2c7/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/HadoopShellExecutable.java ---------------------------------------------------------------------- diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/HadoopShellExecutable.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/HadoopShellExecutable.java index 42b83f0..ce19500 100644 --- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/HadoopShellExecutable.java +++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/common/HadoopShellExecutable.java @@ -55,8 +55,7 @@ public class HadoopShellExecutable extends AbstractExecutable { final Constructor<? extends AbstractHadoopJob> constructor = ClassUtil.forName(mapReduceJobClass, AbstractHadoopJob.class).getConstructor(); final AbstractHadoopJob job = constructor.newInstance(); String[] args = params.trim().split("\\s+"); - logger.info("parameters of the HadoopShellExecutable:"); - logger.info(params); + logger.info("parameters of the HadoopShellExecutable: {}", params); int result; StringBuilder log = new StringBuilder(); try { http://git-wip-us.apache.org/repos/asf/kylin/blob/32b8f2c7/server-base/src/main/java/org/apache/kylin/rest/service/DiagnosisService.java ---------------------------------------------------------------------- diff --git a/server-base/src/main/java/org/apache/kylin/rest/service/DiagnosisService.java b/server-base/src/main/java/org/apache/kylin/rest/service/DiagnosisService.java index 8208596..b473071 100644 --- a/server-base/src/main/java/org/apache/kylin/rest/service/DiagnosisService.java +++ b/server-base/src/main/java/org/apache/kylin/rest/service/DiagnosisService.java @@ -84,9 +84,9 @@ public class DiagnosisService extends BasicService { private void runDiagnosisCLI(String[] args) throws IOException { File cwd = new File(""); - logger.info("Current path: " + cwd.getAbsolutePath()); + logger.debug("Current path: " + cwd.getAbsolutePath()); - logger.info("DiagnosisInfoCLI args: " + Arrays.toString(args)); + logger.debug("DiagnosisInfoCLI args: " + Arrays.toString(args)); File script = new File(KylinConfig.getKylinHome() + File.separator + "bin", "diag.sh"); if (!script.exists()) { throw new RuntimeException("diag.sh not found at " + script.getAbsolutePath()); @@ -94,12 +94,7 @@ public class DiagnosisService extends BasicService { String diagCmd = script.getAbsolutePath() + " " + StringUtils.join(args, " "); CliCommandExecutor executor = KylinConfig.getInstanceFromEnv().getCliCommandExecutor(); - Pair<Integer, String> cmdOutput = executor.execute(diagCmd, new org.apache.kylin.common.util.Logger() { - @Override - public void log(String message) { - logger.info(message); - } - }); + Pair<Integer, String> cmdOutput = executor.execute(diagCmd); if (cmdOutput.getKey() != 0) { throw new RuntimeException("Failed to generate diagnosis package."); http://git-wip-us.apache.org/repos/asf/kylin/blob/32b8f2c7/tool/src/main/java/org/apache/kylin/tool/CubeMetaExtractor.java ---------------------------------------------------------------------- diff --git a/tool/src/main/java/org/apache/kylin/tool/CubeMetaExtractor.java b/tool/src/main/java/org/apache/kylin/tool/CubeMetaExtractor.java index 188524d..30bbb5e 100644 --- a/tool/src/main/java/org/apache/kylin/tool/CubeMetaExtractor.java +++ b/tool/src/main/java/org/apache/kylin/tool/CubeMetaExtractor.java @@ -285,7 +285,7 @@ public class CubeMetaExtractor extends AbstractInfoExtractor { objectMapper.writeValue(f, rootNode); } } catch (JsonProcessingException ex) { - logger.info("cannot parse file {}", f); + logger.warn("cannot parse file {}", f); } }
