KYLIN-2337 Remove expensive toString in SortedIteratorMergerWithLimit Signed-off-by: Yang Li <liy...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/7509beee Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/7509beee Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/7509beee Branch: refs/heads/master-hbase1.x Commit: 7509beeeaaf1d4a50bb82fd83dff5516276b9b9e Parents: 1087f7a Author: kangkaisen <kangkai...@live.com> Authored: Thu Dec 29 21:37:26 2016 +0800 Committer: Yang Li <liy...@apache.org> Committed: Sat Jan 7 09:35:00 2017 +0800 ---------------------------------------------------------------------- core-cube/src/main/java/org/apache/kylin/gridtable/GTRecord.java | 1 + .../kylin/storage/gtrecord/SortedIteratorMergerWithLimit.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/7509beee/core-cube/src/main/java/org/apache/kylin/gridtable/GTRecord.java ---------------------------------------------------------------------- diff --git a/core-cube/src/main/java/org/apache/kylin/gridtable/GTRecord.java b/core-cube/src/main/java/org/apache/kylin/gridtable/GTRecord.java index 4d26029..f4480c8 100644 --- a/core-cube/src/main/java/org/apache/kylin/gridtable/GTRecord.java +++ b/core-cube/src/main/java/org/apache/kylin/gridtable/GTRecord.java @@ -234,6 +234,7 @@ public class GTRecord implements Comparable<GTRecord>, Cloneable { return toString(info.colAll); } + /** toString for MemoryHungry Measure is expensive, please invoke carefully */ public String toString(ImmutableBitSet selectedColumns) { Object[] values = new Object[selectedColumns.cardinality()]; getValues(selectedColumns, values); http://git-wip-us.apache.org/repos/asf/kylin/blob/7509beee/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SortedIteratorMergerWithLimit.java ---------------------------------------------------------------------- diff --git a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SortedIteratorMergerWithLimit.java b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SortedIteratorMergerWithLimit.java index 2f2691e..6a7e713 100644 --- a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SortedIteratorMergerWithLimit.java +++ b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/SortedIteratorMergerWithLimit.java @@ -126,7 +126,7 @@ public class SortedIteratorMergerWithLimit<E extends Cloneable> extends SortedIt //TODO: remove this check when validated if (last != null) { - Preconditions.checkState(comparator.compare(last, fetched) <= 0, "Not sorted! last: " + last + " fetched: " + fetched); + Preconditions.checkState(comparator.compare(last, fetched) <= 0, "Not sorted!"); } last = fetched;
