Repository: kylin Updated Branches: refs/heads/master-hbase1.x 982e8cf2a -> c47f4ad57 (forced update)
KYLIN-2342 When NoClassDefFoundError occurred in building cube, no error in kylin.log Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/e043d5fa Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/e043d5fa Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/e043d5fa Branch: refs/heads/master-hbase1.x Commit: e043d5fad8ccf420b1c0e744ee87a237cd7babd7 Parents: e6a84c5 Author: shaofengshi <shaofeng...@apache.org> Authored: Thu Jan 5 10:54:33 2017 +0800 Committer: shaofengshi <shaofeng...@apache.org> Committed: Thu Jan 5 12:01:36 2017 +0800 ---------------------------------------------------------------------- .../org/apache/kylin/rest/controller/CubeController.java | 4 ++-- .../org/apache/kylin/rest/controller/TableController.java | 10 ++++++---- .../org/apache/kylin/rest/init/InitialTaskManager.java | 2 +- 3 files changed, 9 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/e043d5fa/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java ---------------------------------------------------------------------- diff --git a/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java b/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java index 978f477..a9c8321 100644 --- a/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java +++ b/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java @@ -293,7 +293,7 @@ public class CubeController extends BasicController { } return jobService.submitJob(cube, startTime, endTime, startOffset, endOffset, // sourcePartitionOffsetStart, sourcePartitionOffsetEnd, CubeBuildTypeEnum.valueOf(buildType), force, submitter); - } catch (Exception e) { + } catch (Throwable e) { logger.error(e.getLocalizedMessage(), e); throw new InternalErrorException(e.getLocalizedMessage()); } @@ -656,7 +656,7 @@ public class CubeController extends BasicController { cubeService.getCubeDescManager().updateCubeDesc(desc); response.setProperty("result", "success"); response.setProperty("offsets", startOffsets.toString()); - } catch (Exception e) { + } catch (Throwable e) { throw new RuntimeException(e); } http://git-wip-us.apache.org/repos/asf/kylin/blob/e043d5fa/server-base/src/main/java/org/apache/kylin/rest/controller/TableController.java ---------------------------------------------------------------------- diff --git a/server-base/src/main/java/org/apache/kylin/rest/controller/TableController.java b/server-base/src/main/java/org/apache/kylin/rest/controller/TableController.java index 1ab6ba6..ac4ee2f 100644 --- a/server-base/src/main/java/org/apache/kylin/rest/controller/TableController.java +++ b/server-base/src/main/java/org/apache/kylin/rest/controller/TableController.java @@ -112,7 +112,7 @@ public class TableController extends BasicController { if (request.isCalculate()) { tableService.calculateCardinalityIfNotPresent(loaded, submitter); } - } catch (Exception e) { + } catch (Throwable e) { logger.error("Failed to load Hive Table", e); throw new InternalErrorException(e.getLocalizedMessage()); } @@ -133,7 +133,7 @@ public class TableController extends BasicController { unLoadFail.add(tableName); } } - } catch (Exception e) { + } catch (Throwable e) { logger.error("Failed to unload Hive Table", e); throw new InternalErrorException(e.getLocalizedMessage()); } @@ -175,7 +175,8 @@ public class TableController extends BasicController { private List<String> showHiveDatabases() throws IOException { try { return tableService.getHiveDbNames(); - } catch (Exception e) { + } catch (Throwable e) { + logger.error(e.getLocalizedMessage(), e); throw new InternalErrorException(e.getLocalizedMessage()); } } @@ -191,7 +192,8 @@ public class TableController extends BasicController { private List<String> showHiveTables(@PathVariable String database) throws IOException { try { return tableService.getHiveTableNames(database); - } catch (Exception e) { + } catch (Throwable e) { + logger.error(e.getLocalizedMessage(), e); throw new InternalErrorException(e.getLocalizedMessage()); } } http://git-wip-us.apache.org/repos/asf/kylin/blob/e043d5fa/server-base/src/main/java/org/apache/kylin/rest/init/InitialTaskManager.java ---------------------------------------------------------------------- diff --git a/server-base/src/main/java/org/apache/kylin/rest/init/InitialTaskManager.java b/server-base/src/main/java/org/apache/kylin/rest/init/InitialTaskManager.java index 5cf48cb..8bba674 100644 --- a/server-base/src/main/java/org/apache/kylin/rest/init/InitialTaskManager.java +++ b/server-base/src/main/java/org/apache/kylin/rest/init/InitialTaskManager.java @@ -52,7 +52,7 @@ public class InitialTaskManager implements InitializingBean { InitialTask task = (InitialTask) Class.forName(taskClass).newInstance(); logger.info("Running task: " + taskClass); task.execute(); - } catch (Exception e) { + } catch (Throwable e) { logger.error("Initial task failed: " + taskClass, e); } }
