minor, remove unnecessary check in BaseCuboidMapperBase
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/ac3f3b62 Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/ac3f3b62 Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/ac3f3b62 Branch: refs/heads/yang21-cdh5.7 Commit: ac3f3b621f74c8fb224b67ad32ac38aa426d797e Parents: d34af64 Author: Yang Li <liy...@apache.org> Authored: Sun Nov 13 13:12:11 2016 +0800 Committer: Yang Li <liy...@apache.org> Committed: Sun Nov 13 13:12:11 2016 +0800 ---------------------------------------------------------------------- .../kylin/cube/model/CubeJoinedFlatTableEnrich.java | 11 ----------- .../kylin/engine/mr/steps/BaseCuboidMapperBase.java | 2 -- 2 files changed, 13 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/ac3f3b62/core-cube/src/main/java/org/apache/kylin/cube/model/CubeJoinedFlatTableEnrich.java ---------------------------------------------------------------------- diff --git a/core-cube/src/main/java/org/apache/kylin/cube/model/CubeJoinedFlatTableEnrich.java b/core-cube/src/main/java/org/apache/kylin/cube/model/CubeJoinedFlatTableEnrich.java index 8af2297..979af76 100644 --- a/core-cube/src/main/java/org/apache/kylin/cube/model/CubeJoinedFlatTableEnrich.java +++ b/core-cube/src/main/java/org/apache/kylin/cube/model/CubeJoinedFlatTableEnrich.java @@ -20,7 +20,6 @@ package org.apache.kylin.cube.model; import java.util.List; -import org.apache.kylin.common.util.BytesSplitter; import org.apache.kylin.cube.cuboid.Cuboid; import org.apache.kylin.metadata.model.DataModelDesc; import org.apache.kylin.metadata.model.FunctionDesc; @@ -81,16 +80,6 @@ public class CubeJoinedFlatTableEnrich implements IJoinedFlatTableDesc { } } - // sanity check the input record (in bytes) matches what's expected - public void sanityCheck(BytesSplitter bytesSplitter) { - int columnCount = flatDesc.getAllColumns().size(); - if (columnCount != bytesSplitter.getBufferSize()) { - throw new IllegalArgumentException("Expect " + columnCount + " columns, but see " + bytesSplitter.getBufferSize() + " -- " + bytesSplitter); - } - - // TODO: check data types here - } - public CubeDesc getCubeDesc() { return cubeDesc; } http://git-wip-us.apache.org/repos/asf/kylin/blob/ac3f3b62/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/BaseCuboidMapperBase.java ---------------------------------------------------------------------- diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/BaseCuboidMapperBase.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/BaseCuboidMapperBase.java index 0649a0c..dd0a031 100644 --- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/BaseCuboidMapperBase.java +++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/BaseCuboidMapperBase.java @@ -195,8 +195,6 @@ abstract public class BaseCuboidMapperBase<KEYIN, VALUEIN> extends KylinMapper<K } protected void outputKV(Context context) throws IOException, InterruptedException { - intermediateTableDesc.sanityCheck(bytesSplitter); - byte[] rowKey = buildKey(bytesSplitter.getSplitBuffers()); outputKey.set(rowKey, 0, rowKey.length);
