KYLIN-1698 minor bug fix
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/13959553 Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/13959553 Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/13959553 Branch: refs/heads/KYLIN-1971 Commit: 1395955386bb505dd4ddcb5158823552ddc699e4 Parents: 5da63c2 Author: Li Yang <[email protected]> Authored: Thu Nov 3 17:20:42 2016 +0800 Committer: Li Yang <[email protected]> Committed: Thu Nov 3 17:22:21 2016 +0800 ---------------------------------------------------------------------- .../src/main/java/org/apache/kylin/common/util/DateFormat.java | 4 ++++ .../main/java/org/apache/kylin/metadata/model/PartitionDesc.java | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/13959553/core-common/src/main/java/org/apache/kylin/common/util/DateFormat.java ---------------------------------------------------------------------- diff --git a/core-common/src/main/java/org/apache/kylin/common/util/DateFormat.java b/core-common/src/main/java/org/apache/kylin/common/util/DateFormat.java index 2472992..1d70a2d 100644 --- a/core-common/src/main/java/org/apache/kylin/common/util/DateFormat.java +++ b/core-common/src/main/java/org/apache/kylin/common/util/DateFormat.java @@ -138,4 +138,8 @@ public class DateFormat { } return false; } + + public static boolean isDatePattern(String ptn) { + return COMPACT_DATE_PATTERN.equals(ptn) || DEFAULT_DATE_PATTERN.equals(ptn); + } } http://git-wip-us.apache.org/repos/asf/kylin/blob/13959553/core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java ---------------------------------------------------------------------- diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java b/core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java index 1006b83..127d5e1 100644 --- a/core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java +++ b/core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java @@ -77,7 +77,7 @@ public class PartitionDesc { return false; DataType type = partitionDateColumnRef.getType(); - return type.isInt(); + return (type.isInt() || type.isBigInt()) && DateFormat.isDatePattern(partitionDateFormat); } public boolean partitionColumnIsTimeMillis() { @@ -85,7 +85,7 @@ public class PartitionDesc { return false; DataType type = partitionDateColumnRef.getType(); - return type.isBigInt(); + return type.isBigInt() && !DateFormat.isDatePattern(partitionDateFormat); } public boolean isPartitioned() {
