KYLIN-2110 Ineffective comparison in BooleanDimEnc#equals() Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/ac1d7d66 Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/ac1d7d66 Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/ac1d7d66
Branch: refs/heads/KYLIN-1971 Commit: ac1d7d66e919f52fd2575c54311979d0c412ef5c Parents: 30a4162 Author: shaofengshi <shaofeng...@apache.org> Authored: Thu Oct 20 14:33:23 2016 +0800 Committer: shaofengshi <shaofeng...@apache.org> Committed: Thu Oct 20 14:33:23 2016 +0800 ---------------------------------------------------------------------- .../main/java/org/apache/kylin/dimension/BooleanDimEnc.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/ac1d7d66/core-metadata/src/main/java/org/apache/kylin/dimension/BooleanDimEnc.java ---------------------------------------------------------------------- diff --git a/core-metadata/src/main/java/org/apache/kylin/dimension/BooleanDimEnc.java b/core-metadata/src/main/java/org/apache/kylin/dimension/BooleanDimEnc.java index f32724c..a88d1a2 100644 --- a/core-metadata/src/main/java/org/apache/kylin/dimension/BooleanDimEnc.java +++ b/core-metadata/src/main/java/org/apache/kylin/dimension/BooleanDimEnc.java @@ -182,11 +182,7 @@ public class BooleanDimEnc extends DimensionEncoding { return true; if (o == null || getClass() != o.getClass()) return false; - - BooleanDimEnc that = (BooleanDimEnc) o; - - return fixedLen == that.fixedLen; - + return true; } @Override
