KYLIN-1714 clean up unused methods
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/8d178b91 Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/8d178b91 Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/8d178b91 Branch: refs/heads/master Commit: 8d178b91ffdedca077b27aef3e1170eced8433cd Parents: f31ad6e Author: Li Yang <liy...@apache.org> Authored: Fri May 20 15:37:46 2016 +0800 Committer: Li Yang <liy...@apache.org> Committed: Fri May 20 15:37:46 2016 +0800 ---------------------------------------------------------------------- .../java/org/apache/kylin/engine/mr/BatchCubingJobBuilder2.java | 5 ----- .../java/org/apache/kylin/engine/mr/BatchMergeJobBuilder2.java | 5 ----- 2 files changed, 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/8d178b91/engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchCubingJobBuilder2.java ---------------------------------------------------------------------- diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchCubingJobBuilder2.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchCubingJobBuilder2.java index 853eca0..7ac94f8 100644 --- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchCubingJobBuilder2.java +++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchCubingJobBuilder2.java @@ -60,7 +60,6 @@ public class BatchCubingJobBuilder2 extends JobBuilderSupport { result.addTask(createFactDistinctColumnsStepWithStats(jobId)); result.addTask(createBuildDictionaryStep(jobId)); result.addTask(createSaveStatisticsStep(jobId)); - addOtherStepBeforeCubing(result); outputSide.addStepPhase2_BuildDictionary(result); // Phase 3: Build Cube @@ -100,10 +99,6 @@ public class BatchCubingJobBuilder2 extends JobBuilderSupport { return result; } - protected void addOtherStepBeforeCubing(CubingJob result) { - - } - private MapReduceExecutable createInMemCubingStep(String jobId, String cuboidRootPath) { // base cuboid job MapReduceExecutable cubeStep = new MapReduceExecutable(); http://git-wip-us.apache.org/repos/asf/kylin/blob/8d178b91/engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchMergeJobBuilder2.java ---------------------------------------------------------------------- diff --git a/engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchMergeJobBuilder2.java b/engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchMergeJobBuilder2.java index 08ddaf8..e151674 100644 --- a/engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchMergeJobBuilder2.java +++ b/engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchMergeJobBuilder2.java @@ -64,7 +64,6 @@ public class BatchMergeJobBuilder2 extends JobBuilderSupport { // Phase 1: Merge Dictionary result.addTask(createMergeDictionaryStep(mergingSegmentIds)); result.addTask(createMergeStatisticsStep(cubeSegment, mergingSegmentIds, getStatisticsPath(jobId))); - addOtherStepBeforeMerge(result); outputSide.addStepPhase1_MergeDictionary(result); // Phase 2: Merge Cube Files @@ -108,8 +107,4 @@ public class BatchMergeJobBuilder2 extends JobBuilderSupport { return mergeCuboidDataStep; } - protected void addOtherStepBeforeMerge(CubingJob result) { - - } - }
