KYLIN-1678 Metadata cleanup tool use wrong enum to check wrong job status

Signed-off-by: lidongsjtu <lid...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/aa98a909
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/aa98a909
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/aa98a909

Branch: refs/heads/1.5.x-CDH5.7
Commit: aa98a909e3a7c897b48d822152e26d0124dff662
Parents: d26667b
Author: Folin Chen <chenfo...@gmail.com>
Authored: Fri May 13 18:30:32 2016 +0800
Committer: lidongsjtu <lid...@apache.org>
Committed: Fri May 13 20:37:44 2016 +0800

----------------------------------------------------------------------
 .../java/org/apache/kylin/engine/mr/steps/MetadataCleanupJob.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/aa98a909/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MetadataCleanupJob.java
----------------------------------------------------------------------
diff --git 
a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MetadataCleanupJob.java
 
b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MetadataCleanupJob.java
index b88a170..7967055 100644
--- 
a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MetadataCleanupJob.java
+++ 
b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/MetadataCleanupJob.java
@@ -32,6 +32,7 @@ import org.apache.kylin.job.constant.JobStatusEnum;
 import org.apache.kylin.job.dao.ExecutableDao;
 import org.apache.kylin.job.dao.ExecutableOutputPO;
 import org.apache.kylin.job.dao.ExecutablePO;
+import org.apache.kylin.job.execution.ExecutableState;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -150,7 +151,7 @@ public class MetadataCleanupJob extends AbstractHadoopJob {
         for (ExecutablePO executable : allExecutable) {
             long lastModified = executable.getLastModified();
             ExecutableOutputPO output = 
executableDao.getJobOutput(executable.getUuid());
-            if (System.currentTimeMillis() - lastModified > 
TIME_THREADSHOLD_FOR_JOB && 
(output.getStatus().equals(JobStatusEnum.FINISHED.toString()) || 
output.getStatus().equals(JobStatusEnum.DISCARDED.toString()))) {
+            if (System.currentTimeMillis() - lastModified > 
TIME_THREADSHOLD_FOR_JOB && 
(ExecutableState.SUCCEED.toString().equals(output.getStatus()) || 
ExecutableState.DISCARDED.toString().equals(output.getStatus()))) {
                 toDeleteResource.add(ResourceStore.EXECUTE_RESOURCE_ROOT + "/" 
+ executable.getUuid());
                 
toDeleteResource.add(ResourceStore.EXECUTE_OUTPUT_RESOURCE_ROOT + "/" + 
executable.getUuid());
 

Reply via email to