KYLIN-1329 Bug fix for ACL exception when deleting model
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/109e1daf Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/109e1daf Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/109e1daf Branch: refs/heads/2.x-staging Commit: 109e1daf82cf784fc02b6bd6f17a057ada79ad1b Parents: bb6e1f8 Author: lidongsjtu <don...@ebay.com> Authored: Tue Jan 19 10:29:22 2016 +0800 Committer: lidongsjtu <lid...@apache.org> Committed: Tue Jan 19 17:17:00 2016 +0800 ---------------------------------------------------------------------- .../main/java/org/apache/kylin/rest/service/AccessService.java | 4 ++++ 1 file changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/109e1daf/server/src/main/java/org/apache/kylin/rest/service/AccessService.java ---------------------------------------------------------------------- diff --git a/server/src/main/java/org/apache/kylin/rest/service/AccessService.java b/server/src/main/java/org/apache/kylin/rest/service/AccessService.java index cd93eba..5370bba 100644 --- a/server/src/main/java/org/apache/kylin/rest/service/AccessService.java +++ b/server/src/main/java/org/apache/kylin/rest/service/AccessService.java @@ -219,6 +219,10 @@ public class AccessService { public void clean(AclEntity ae, boolean deleteChildren) { Assert.notNull(ae, "Acl domain object required"); + // For those may have null uuid, like DataModel, won't delete Acl. + if (ae.getId() == null) + return; + ObjectIdentity objectIdentity = new ObjectIdentityImpl(ae.getClass(), ae.getId()); try {
