yesamer commented on code in PR #6577:
URL:
https://github.com/apache/incubator-kie-drools/pull/6577#discussion_r2791994511
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/lang/EvaluationContext.java:
##########
@@ -74,4 +74,5 @@ default void setPerformRuntimeTypeCheck(boolean
performRuntimeTypeCheck) {
default void enterFrame(int size) {
// Default implementation does nothing
}
+
Review Comment:
@ChinchuAjith I guess you can remove this new added line, so the
EvaluationContext.java will no longer listened here.
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/lang/ast/UnaryTestNode.java:
##########
@@ -224,77 +224,122 @@ static Boolean areElementsEqual(Object left, Object
right) {
() -> Boolean.FALSE)
);
}
+ private Object evaluateRightValue(EvaluationContext context, Object left) {
Review Comment:
@ChinchuAjith Can you please add UnitTests to verify those new introduced
methods? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
