Rikkola commented on code in PR #6516:
URL:
https://github.com/apache/incubator-kie-drools/pull/6516#discussion_r2513941876
##########
drools-core/src/main/java/org/drools/core/phreak/EagerPhreakBuilder.java:
##########
@@ -1098,8 +1098,8 @@ private static TupleImpl
insertPeerLeftTuple(InternalWorkingMemory wm,
if (insert) {
TerminalNode rtn = (TerminalNode) node;
InternalAgenda agenda = wm.getAgenda();
- RuleAgendaItem agendaItem =
AlphaTerminalNode.getRuleAgendaItem(wm, agenda, rtn, insert);
- PhreakRuleTerminalNode.doLeftTupleInsert(rtn,
agendaItem.getRuleExecutor(), agenda, agendaItem,
+ RuleAgendaItem agendaItem =
AlphaTerminalNode.getRuleAgendaItem(wm, rtn, insert);
+ PhreakRuleTerminalNode.doLeftTupleInsert(wm, rtn,
agendaItem.getRuleExecutor(), agenda, agendaItem,
Review Comment:
Not related to this change, but I noticed this passes in agendaItem and rule
exectutor from agendaItem. Could it just pass agendaItem and get rule executor
once in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
