tkobayas commented on PR #6473: URL: https://github.com/apache/incubator-kie-drools/pull/6473#issuecomment-3375126101
> In this case, would it be safer using toCollection(LinkedHashSet::new), instead of using toSet() and wrapping it in LinkedHashSet, to ensure the deterministic order? Thanks, `toCollection(LinkedHashSet::new)` is better :) > And for the AST section using RHS order, I was thinking that streaming existingDecls directly may lead to the encounter order driven by existingDecls and thus lose the RHS order. I am wondering whether we do need that order in this case. The RHS order is not important. As long as `extractUsedDeclarations` returns a `LinkedHashSet`, the compilation issue of `D.on(var_A, var_B, ...)` vs `LambdaConsequence` is solved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
