pibizza opened a new pull request, #6488:
URL: https://github.com/apache/incubator-kie-drools/pull/6488
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
More progress in the cleanup of the drl engine code. This is mostly related
to phreak code.
- I have moved a number of statich methods to SegmentMemory and
SegmentPrototype. This has made the code cleaner
- I have reordered the parameters in a number of methods following a more
sensible approach - namely first global objects like RuleBase, ReteEvaluator
and the likes, then Path/Segment memories, then nodes, then tuples, and finally
flags. It was not always clean and easy to do, so you will find possibly still
something not perfect, but still.
- I have reformetted the code with the drools formatter. Code is now a bit
cleaner and more uniform as you look at it.
@mariofusco please can you look at
org.drools.core.reteoo.SegmentMemory.mergeBitMasks(SegmentMemory). The code is
copy pasted from the corresponding code in LazyPhreakBuilder, but it seems
wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
