DimaSol commented on PR #6469: URL: https://github.com/apache/incubator-kie-drools/pull/6469#issuecomment-3347798498
Thanks @tkobayas. I’ve seen the failures and I’m planning to work on a fix to properly distinguish between static and dynamic expressions. Initially, I overlooked the dynamic expression use case, but I find the current caching approach even more concerning: this map could grow unbounded over time, leading to significant memory usage at scale (e.g., millions of facts with many dynamic values). That’s why I’d prefer to finalize the implementation I started. Even if we keep caching for dynamic regex expressions, it should at least use an LRU cache with strict, configurable limits. My main open question is about the benefits of using D.eval in the lambda test method. Do you think there’s any advantage to going down this path for static regex as well, or would it be fine to use the class regex member directly without D.eval? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
