fantonangeli commented on code in PR #3269:
URL:
https://github.com/apache/incubator-kie-tools/pull/3269#discussion_r2333936460
##########
packages/sonataflow-image-common/resources/modules/kogito-maven/common/configure:
##########
@@ -33,11 +33,6 @@ then
mv /usr/share/apache-maven-"${MAVEN_VERSION}" ${MAVEN_HOME}
else
echo "---> Maven already present in the current context"
- # TODO: Remove this temporary solution in favor of the
-DnoMavenVersionCheck flag once it's available
- # https://github.com/quarkusio/quarkus/issues/46105
- # Installs Maven for version 3.9.6 in order to be compatible with the
quarkus-maven-plugin minimum requirements (on Quarkus 3.15.3.1).
- echo "---> Installing Maven 3.9.6"
- ln -sf "${ALTERNATIVE_MAVEN_HOME}/bin/mvn" "${MAVEN_HOME}/bin/mvn"
Review Comment:
@ricardozanini I think that `tar ...` command is needed by the command at
line 33:
```
mv /usr/share/apache-maven-"${MAVEN_VERSION}" ${MAVEN_HOME}
```
I guess we can move the `tar` to that block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
