fantonangeli commented on issue #3271: URL: https://github.com/apache/incubator-kie-tools/issues/3271#issuecomment-3281738228
@michael-willingham Thank you so much for contributing, but please take your time, no need to hurry 😉 > I'm assuming there's a bit more needed than the one line diff I proposed Actually, yes. IMO it would be better to make it optional using a json for this setting with a default to `false`, to keep the current behaviour as default. We have an example in a similar package: - the documentation: https://github.com/apache/incubator-kie-tools/blob/main/packages/sonataflow-deployment-webapp/README.md#optional-customizations - The default values: https://github.com/apache/incubator-kie-tools/blob/main/packages/sonataflow-deployment-webapp/src/AppConstants.ts#L28 - the static json: https://github.com/apache/incubator-kie-tools/blob/main/packages/sonataflow-deployment-webapp/static/sonataflow-deployment-webapp-data.json - the point where the json is read in the app: https://github.com/apache/incubator-kie-tools/blob/f4ef26380b1f039a39753f3cbdd74e7c8766b4f6/packages/sonataflow-deployment-webapp/src/context/AppContextProvider.tsx#L40 - the final use of our setting: https://github.com/apache/incubator-kie-tools/blob/f4ef26380b1f039a39753f3cbdd74e7c8766b4f6/packages/sonataflow-deployment-webapp/src/runtimeTools/contexts/DeploymentWorkflowDefinitionListContextProvider.tsx#L28 If you feel it is too much, just let me know, and we will do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
