gitgabrio commented on code in PR #6426:
URL:
https://github.com/apache/incubator-kie-drools/pull/6426#discussion_r2282404312
##########
kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/compiler/UnnamedImportUtils.java:
##########
@@ -45,31 +45,32 @@ public static boolean isInUnnamedImport(DMNNode node,
DMNModelImpl model) {
return false;
}
- public static void processMergedModel(DMNModelImpl parentModel,
DMNModelImpl mergedModel) {
+ public static void processMergedModel(DMNModelImpl importingModel,
DMNModelImpl importedModel) {
// incubator-kie-issues#852: The idea is to not treat the anonymous
models as import, but to "merge" them with original opne,
// Here we try to put all the definitions from the "imported" model
inside the parent one
- Definitions parentDefinitions = parentModel.getDefinitions();
- Definitions mergedDefinitions = mergedModel.getDefinitions();
+ Definitions importingDefinitions = importingModel.getDefinitions();
+ Definitions importedDefinitions = importedModel.getDefinitions();
- mergeDefinitions(parentDefinitions, mergedDefinitions);
+ mergeDefinitions(importingDefinitions, importedDefinitions);
- mergedModel.getTypeRegistry().getTypes().forEach((s, stringDMNTypeMap)
->
+ importedModel.getTypeRegistry().getTypes().forEach((s,
stringDMNTypeMap) ->
stringDMNTypeMap.values().
-
forEach(dmnType -> parentModel.getTypeRegistry().registerType(dmnType)));
- mergedModel.getDecisions().forEach(parentModel::addDecision);
- mergedModel.getImportAliasesForNS().forEach((s, qName) ->
parentModel.setImportAliasForNS(s, qName.getNamespaceURI(),
qName.getLocalPart()));
+
forEach(dmnType -> importingModel.getTypeRegistry().registerType(dmnType)));
+ importedModel.getDecisions().forEach(importingModel::addDecision);
+ importedModel.getInputs().forEach(importingModel::addInput);
Review Comment:
NOTICE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
