yesamer commented on code in PR #6406:
URL:
https://github.com/apache/incubator-kie-drools/pull/6406#discussion_r2275892076
##########
kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/ast/DMNBaseNode.java:
##########
@@ -111,8 +111,8 @@ public void setDependencies(Map<String, DMNNode>
dependencies) {
this.dependencies = dependencies;
}
- public void addDependency(String name, DMNNode dependency) {
- this.dependencies.put(name, dependency);
+ public void addDependency(String nameWithModelNamespace, DMNNode
dependency) {
+ this.dependencies.put(nameWithModelNamespace, dependency);
Review Comment:
@AthiraHari77 @gitgabrio Do you think it can be useful to add a comment
above the `dependency` declaration explaining that the key is in `namespace +
"."+ name` format?
##########
kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/ast/DMNBaseNode.java:
##########
@@ -111,8 +111,8 @@ public void setDependencies(Map<String, DMNNode>
dependencies) {
this.dependencies = dependencies;
}
- public void addDependency(String name, DMNNode dependency) {
- this.dependencies.put(name, dependency);
+ public void addDependency(String nameWithModelNamespace, DMNNode
dependency) {
+ this.dependencies.put(nameWithModelNamespace, dependency);
Review Comment:
@AthiraHari77 @gitgabrio Do you think it can be useful to add a comment
above the `dependency` declaration explaining that the key is in `namespace +
"."+ name` format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
