tkobayas commented on code in PR #6414:
URL:
https://github.com/apache/incubator-kie-drools/pull/6414#discussion_r2268443422
##########
drools-model/drools-model-codegen/src/main/java/org/drools/model/codegen/execmodel/generator/declaredtype/POJOGenerator.java:
##########
@@ -153,7 +153,38 @@ private void createPOJO(TypeDeclarationDescr typeDescr) {
MARKER_INTERFACES)
.toClassDeclaration();
packageModel.addGeneratedPOJO(generatedClass);
- addTypeMetadata(typeDescr.getTypeName());
+
+ // Add type metadata including custom annotations
+ String fullTypeName = pkg.getName() + "." + typeDescr.getTypeName();
+ MethodCallExpr typeMetaDataCall = registerTypeMetaData(fullTypeName);
+
+ // Add custom metadata from non-defined annotations
+ Map<String, Object> classMetaData =
descrDeclaredTypeDefinition.getClassMetaData();
+ for (Map.Entry<String, Object> entry : classMetaData.entrySet()) {
+ typeMetaDataCall = new MethodCallExpr(typeMetaDataCall,
ADD_ANNOTATION_CALL);
+ typeMetaDataCall.addArgument(toStringLiteral(entry.getKey()));
+ addAnnotationValueIfNotNull(typeMetaDataCall, entry.getValue());
+ }
+
+ // Add field metadata
+ for (DescrFieldDefinition field :
descrDeclaredTypeDefinition.getFields()) {
+ Map<String, Object> fieldMetaData = field.getFieldMetaData();
+ if (!fieldMetaData.isEmpty()) {
+ // First, add the field to the TypeMetaData
+ typeMetaDataCall = new MethodCallExpr(typeMetaDataCall,
"withField");
+
typeMetaDataCall.addArgument(toStringLiteral(field.getFieldName()));
+
+ // Then add each annotation as field metadata
+ for (Map.Entry<String, Object> entry :
fieldMetaData.entrySet()) {
+ typeMetaDataCall = new MethodCallExpr(typeMetaDataCall,
"withFieldAnnotation");
+
typeMetaDataCall.addArgument(toStringLiteral(field.getFieldName()));
+
typeMetaDataCall.addArgument(toStringLiteral(entry.getKey()));
+ addAnnotationValueIfNotNull(typeMetaDataCall,
entry.getValue());
+ }
+ }
+ }
+
+ packageModel.addTypeMetaDataExpressions(typeMetaDataCall);
}
private void addTypeMetadata(String typeName) {
Review Comment:
`addTypeMetadata` is called by another method. Not a dead code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
